WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#20159 closed defect (bug) (fixed)

Typo in sites/users network admin bulk actions

Reported by: duck_ Owned by: duck_
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.0
Component: Network Admin Keywords:
Focuses: multisite Cc:

Description

if ( $_GET['action'] != -1 || $_POST['action2'] != -1 )
    $doaction = $_POST['action'] != -1 ? $_POST['action'] : $_POST['action2'];

Checking $_GET for action and $_POST for action2. The line can be dropped since it will always be true and it doesn't matter if $doaction is set to -1.

Looks like it's from [13609] and [13918].

Attachments (1)

20159.diff (1.3 KB) - added by duck_ 2 years ago.

Download all attachments as: .zip

Change History (2)

duck_2 years ago

comment:1 duck_2 years ago

  • Owner set to duck_
  • Resolution set to fixed
  • Status changed from new to closed

In [20092]:

Drop unnecessary if-statements which also have some strange logic. Fixes #20159.

Note: See TracTickets for help on using tickets.