Function url_shorten() enhancement

[mulvane]

The function url_open is included in the wp_admin/includes/misc.php and is not usable unless loaded. This is not loaded by default so not available site wide. Also, the function is very static as of right now in its use with no defined options. Options to set length of the shortened url and the ability to turn on off the cutting of the leading "​http://www" and the trailing slashes are included in this patch.

[dd32]

Makes sense to move it to a more neutral location perhaps, but I'd suggest that adding anything other than the length cutoff isn't needed for core.

[mulvane]

I mostly agree but there are more than a few sites where cutting off the www or removing the trailing slash will break the link. For visual purposes, its nice to see them when they are required.

[nacin]

This seems like a good candidate for formatting.php, versus the generic (and early-loaded) functions.php.

mulvane, you make a good point, but I agree with dd32 that we shouldn't deal with anything in core other than the length cut-off.

[chriscct7]

Refreshed patch in the formatting file (as requested by nacin). Updated the function with only the one new parameter, updated the docblocs, moved the unit tests, and added a unit test to cover length

[chriscct7]

tests/phpunit/tests/admin/includesMisc.php needs to be removed after this is commmitted

[ocean90]

The function doesn't support https URLs.

Looks to me like a candidate for deprecate.php.

[chriscct7]

Replying to ocean90:

The function doesn't support https URLs.

Looks to me like a candidate for deprecate.php.

The function didn't originally support it so I didn't add support when I moved it. It could easily add support

[chriscct7]

New version supports HTTPs

[wonderboymusic]

In 35314:

Formatting: move url_shorten() from wp-admin/includes/misc.php to wp-includes/formatting.php for more global access.

Adds unit tests.

Props mulvane, chriscct7.
Fixes #20166.

[swissspidy]

[35314] broke the function docblock (wrong alignment, typo). typo.diff​ aims to fix that.

@DrewAPicture Maybe you can have a look at that during contributor day?

[swissspidy]

In 35813:

Docs: After [35314], fix the DocBlock for url_shorten().

See #20166.

[ocean90]

In 35815:

Docs: After [35314], fix the DocBlock for url_shorten().

Merge of [35813] for the 4.4 branch.

Props swissspidy.
See #20166.