Make WordPress Core

Opened 19 years ago

Closed 19 years ago

Last modified 18 years ago

#2017 closed defect (bug) (fixed)

JavaScript for "rel" field in links references wrong id

Reported by: filosofo's profile filosofo Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.0
Component: Administration Keywords: links, rel, link_rel, has patch
Focuses: Cc:

Description

While looking at another problem (#2016), I noticed that the Javascript "upit" function used for the Link options was throwing errors with almost every radio button click.

The problem: upit tries to assign a value to an object with id="rel", but no such object exists. Instead, it means to assign those values to id="link_rel".

The attached patch now avoids Javascript errors as well as correctly populating the "rel" field when one is creating or editing links.

Attachments (1)

admin-header.php.diff (548 bytes) - added by filosofo 19 years ago.

Download all attachments as: .zip

Change History (3)

#1 @ryan
19 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3256]) Use link_rel id. Props filosofo. fixes #2017

#2 @(none)
18 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.