Context Navigation

← Previous Ticket
Next Ticket →

#20175 closed defect (bug) (fixed)

"Trash" should not be a bulk action when user can't delete a post at all

Reported by:	markoheijnen	Owned by:	wonderboymusic
Priority:	normal	Milestone:	4.1
Component:	Posts, Post Types	Version:	3.3.1
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

When a user can't delete posts at all for a certain post type the bulk action to delete posts is useless.

Not sure if the following check is correct:

		if ( current_user_can( $post_type_object->cap->delete_post ) ) {
			if ( $this->is_trash || !EMPTY_TRASH_DAYS )
				$actions['delete'] = __( 'Delete Permanently' );
			else
				$actions['trash'] = __( 'Move to Trash' );
		}

Maybe the edit/restore functionality should have some similar check

Attachments (1)

trash-patch.patch (811 bytes ) - added by mvd7793 14 years ago.: Fixes the bug in ticket 20175

Download all attachments as: .zip

Change History (9)

#1 @coffee2code
14 years ago

Keywords needs-patch added
Version → 3.3.1

#2 @nacin
14 years ago

delete_posts should be plural. Otherwise, seems good at a glance.

@mvd7793
14 years ago

Attachment trash-patch.patch added

Fixes the bug in ticket 20175

#3 @mvd7793
14 years ago

Keywords has-patch added; needs-patch removed

#4 @mvd7793
14 years ago

Cc mvd7793 added

#5 @nacin
12 years ago

Component Trash → Posts, Post Types

#6 @danielbachhuber
12 years ago

Milestone Awaiting Review → 4.1

I just stumbled upon this too. Patch looks good.

#7 @wonderboymusic
12 years ago

Owner set to wonderboymusic
Resolution → fixed
Status new → closed

In 29757:

If the current user does not have the delete_posts cap on the current post type, don't list delete or trash as bulk actions for the relevant context of Post list table.

Props mvd7793.
Fixes #20175.

#8 @nacin
12 years ago

Looks good.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#20175 closed defect (bug) (fixed)

"Trash" should not be a bulk action when user can't delete a post at all

Description

Attachments (1)

Change History (9)

#1 @coffee2code 14 years ago

#2 @nacin 14 years ago

@mvd7793 14 years ago

#3 @mvd7793 14 years ago

#4 @mvd7793 14 years ago

#5 @nacin 12 years ago

#6 @danielbachhuber 12 years ago

#7 @wonderboymusic 12 years ago

#8 @nacin 12 years ago