WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #20187, comment 5


Ignore:
Timestamp:
03/07/12 01:18:07 (3 years ago)
Author:
merty
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #20187, comment 5

    initial v1  
    11Technically there is no difference but extension_loaded('sockets') looks like a better coding practice to me. 
    22 
    3 The actual issue, however, is not detecting the availability of php_sockets. The issue is, wherever dl() is not available, the if-check silently fails and therefore it does not set $mod_sockets's value to FALSE even though it should. 
     3The actual issue, however, isn't detecting the availability of php_sockets. The issue is, wherever dl() is not available, the if-check silently fails and therefore it does not set $mod_sockets's value to FALSE even though it should. 
    44 
    55dl() is deprecated in PHP 5.3 and completely removed in PHP6. Either we can completely remove the part where it tries to load the extension in the runtime, or we can just check the availability of dl() and prevent unexpected behaviors.