WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#20196 closed defect (bug) (invalid)

No PHP closure tag in index.php

Reported by: carldanley's profile carldanley Owned by:
Milestone: Priority: normal
Severity: trivial Version: 3.4
Component: General Keywords: needs-patch
Focuses: Cc:

Description

small bug, thats all. also, this is my first patch. index.php is missing a php closure tag.

Attachments (1)

index.diff​ (286 bytes) - added by carldanley 13 years ago.
the fix for this.

Download all attachments as: .zip

Change History (4)

@carldanley
13 years ago

the fix for this.

#1 @dd32
13 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

PHP files may optionally include the closing ?> tag. As of 3.4, we've removed them from all files: [19712] (I think the alot had a nice breakfast that night - #13237)

Last edited 13 years ago by dd32 (previous) (diff)

#2 @nacin
13 years ago

Indeed, leaving closing PHP tags off files is valid, acceptable, and in some cases even preferred (see ​http://www.php.net/manual/en/language.basic-syntax.instruction-separation.php for a note). As dd32 points out, we recently altered our standard to omit them everywhere. But thanks for the patch!

#3 @carldanley
13 years ago

No worries! It was more of a nervous submission for a first patch :) Trying to get involved more. Will continue to read more before submitting further patches. Glad this went pretty easily.

Note: See TracTickets for help on using tickets.