Context Navigation

← Previous Ticket
Next Ticket →

#20196 closed defect (bug) (invalid)

No PHP closure tag in index.php

Reported by:	carldanley	Owned by:
Priority:	normal	Milestone:
Component:	General	Version:	3.4
Severity:	trivial	Keywords:	needs-patch
Cc:		Focuses:

Description

small bug, thats all. also, this is my first patch. index.php is missing a php closure tag.

Attachments (1)

index.diff (286 bytes ) - added by carldanley 14 years ago.: the fix for this.

Download all attachments as: .zip

Change History (4)

@carldanley
14 years ago

Attachment index.diff added

the fix for this.

#1 @dd32
14 years ago

Milestone Awaiting Review
Resolution → invalid
Status new → closed

PHP files may optionally include the closing ?> tag. As of 3.4, we've removed them from all files: [19712] (I think the alot had a nice breakfast that night - #13237)

Last edited 14 years ago by dd32 (previous) (diff)

#2 @nacin
14 years ago

Indeed, leaving closing PHP tags off files is valid, acceptable, and in some cases even preferred (see http://www.php.net/manual/en/language.basic-syntax.instruction-separation.php for a note). As dd32 points out, we recently altered our standard to omit them everywhere. But thanks for the patch!

#3 @carldanley
14 years ago

No worries! It was more of a nervous submission for a first patch :) Trying to get involved more. Will continue to read more before submitting further patches. Glad this went pretty easily.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core