Make WordPress Core

Opened 4 years ago

Closed 16 months ago

Last modified 16 months ago

#20206 closed enhancement (fixed)

WXR unnecessarily includes all post authors

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.3
Component: Export Keywords: has-patch
Focuses: Cc:


If you're exporting just one post type (from Tools -> Export), the resulting WXR file still includes all authors from the posts table, regardless if they are the author of a post of the post type being exported. This can be particularly noticable for Pages (which are often only authored by a small number of different users on the site) and for custom post types.

This means when you subsequently import the file you'll be asked to map a complete list of all authors from the exported site, even if they have no posts in the WXR file being imported.

Attachments (2)

20206.patch (1.6 KB) - added by johnbillion 4 years ago.
20206.2.diff (1.3 KB) - added by jeremyfelt 4 years ago.
Updated patch using $post_ids

Download all attachments as: .zip

Change History (12)

@johnbillion4 years ago

comment:1 @johnbillion4 years ago

  • Keywords has-patch added

Patch to only include relevant post authors in the WXR export.

comment:2 @jeremyfelt4 years ago

  • Cc jeremy.felt@… added

I really like this idea. It makes sense to export all of the data based on the selected parameters.

It may make more sense to reuse the $post_ids array so that the query for distinct post authors mirrors the results from the main posts query. Restricting it to post_type could cause the same issue with extra authors for some taxonomies, etc...

The updated patch attached uses the $post_ids array instead.

@jeremyfelt4 years ago

Updated patch using $post_ids

comment:3 @johnbillion4 years ago

Even better!

comment:4 @johnbillion16 months ago

#28450 was marked as a duplicate.

comment:5 @SergeyBiryukov16 months ago

  • Milestone changed from Awaiting Review to 4.0

comment:6 @khromov16 months ago

Glad to see this is getting some traction! Hoping for inclusion in 4.0!

comment:7 @johnbillion16 months ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 28731:

Only include relevant post authors in WXR exports. Fixes #20206. Props jeremyfelt.

comment:8 @nacin16 months ago

Not sure if this requires re-opening, but does this fully cover things like attachments (either attached to a post or as a featured image) that would also need to be (but may not yet be) included in such an export?

comment:9 @johnbillion16 months ago

Good spot.

If you don't limit your export to a certain post type, attachments are included in the export and all author IDs are present and correct, so we're ok.

If you do limit your export to a certain post type, the featured image post is not included in the export and gets lost. This is covered in #17379.

comment:10 @lkraav16 months ago

This is huge. Just had to say that out loud.

Note: See TracTickets for help on using tickets.