set_post_thumbnail(): update_post_meta() could fail

[webord]

So I'm in a project where the defined thumbnail must always be bigger then a certain size, and my problem is whether I can filter to check the size of the image, using a filter on the update_{$meta_type}_metadata, the function set_post_thumbnail(), always return true, so my change is really small so the developer can filter and return false if it pleases;

In my case I would filter that and the content on admin_post_thumbnail_html to Warn the user that he cannot set a thumbnail with this size.

Check out the .diff, and if there any other place that I can change something, to make it better warn me.

[webord]

Changes

[scribu]

Makes sense.

[webord]

Replying to scribu:
Question, what I should do now? I should: patch -p0 < post.diff ?

I don't really know how to patch something I did. Thanks a lot.

[scribu]

Now you wait for someone with commit access to commit your patch.

[webord]

Thanks!

[duck_]

In [20172]:

Use return value of update_post_meta() in set_post_thumbnail() instead of always returning true. Props webord. Fixes #20218.