Administrator role accidently assigned under certain conditions

[davidhouse]

When writing the Role Manager plugin, the role of random users was sometimes set to Administrator after removing certain caps. This patch fixes some lazy coding (it was part of a patch I submitted a few weeks ago, when I didn't totally understand the caps API) and thus the bug.

Trivial severity as i don't think it can happen without the plugin, but it's low hanging fruit :)

[ryan]

(In [3266]) Role fixup from David House. fixes #2024

## What?
Default fonts directory to wp-content/uploads/fonts instead of wp-content/fonts.

## Context links:

• ​https://github.com/WordPress/gutenberg/issues/53965
• ​https://github.com/WordPress/gutenberg/issues/59417
• ​https://make.wordpress.org/core/2024/03/07/unblocking-wp6-5-font-library-and-synced-pattern-overrides/
• ​https://make.wordpress.org/core/2024/03/21/font-library-update-storage-of-font-files/

---
Trac ticket:

Initial testing is showing that fonts are correctly uploading to wp-content/uploads/fonts using both google fonts and manually uploading.

Can we get some tests added to confirm the expected path on Multisite sub-sites? It seems the expected path is wp-content/uploads/sites/<id>}/fonts.

Committed r57878 / ​https://github.com/WordPress/wordpress-develop/commit/f8e1870778cadf3bd48d03fb4e53fd144686ffe9

See ​https://make.wordpress.org/core/2024/05/06/proposal-server-to-client-data-sharing-for-script-modules/

Includes ​https://github.com/WordPress/wordpress-develop/pull/6452
Requires ​https://github.com/WordPress/gutenberg/pull/60952 (this PR builds and registers the @wordpress/api-fetch module).

Trac ticket:

This proof of concept is superseded by ​https://github.com/WordPress/wordpress-develop/pull/6682.

I'm adding my new w.org display name to the .mailmap file. See more context in this @dmsnell's post introducing the .mailmap file: ​https://make.wordpress.org/core/2024/08/14/control-your-contributions-with-mailmap/

@adamziel sadly this doesn't recurse on the remapped email, so the first record rewrites the name and email address for the GUID-like email, but the second line is necessary to rename the commits already associated with zieladam@git.wordpress.org.

I'd push but I can't update your trunk

.mailmap

@@ -10 +10 @@
 Aaron Jorbin <jorbin@git.wordpress.org> <jorbin@602fd350-edb4-49c9-b593-d223f7449a82>
 Adam Silverstein <adamsilverstein@git.wordpress.org> <adamsilverstein@602fd350-edb4-49c9-b593-d223f7449a82>
 Adam Zieliński <zieladam@git.wordpress.org> <zieladam@602fd350-edb4-49c9-b593-d223f7449a82>
+Adam Zieliński <zieladam@git.wordpress.org>
 Alex King <alexkingorg@git.wordpress.org> <alexkingorg@602fd350-edb4-49c9-b593-d223f7449a82>
 Alex Shiels <tellyworth@git.wordpress.org> <tellyworth@602fd350-edb4-49c9-b593-d223f7449a82>
 André <oandregal@git.wordpress.org>

@adamziel I've merged this in [58941]
​https://github.com/wordpress/wordpress-develop/commit/f4761a3f8c5aa6920d4407e3af271ef70db5f305

You now appear as you in the history.

     8  Daniel Bachhuber <danielbachhuber@git.wordpress.org>
     8  Konstantin Kovshenin <kovshenin@git.wordpress.org>
     7  Adam Zieliński <zieladam@git.wordpress.org>
     7  Michael Adams <mdawaffe@git.wordpress.org>
     6  Andrew Duthie <aduth@git.wordpress.org>

but since this PR is built from your own trunk you'll probably need to git reset --hard upstream/trunk otherwise it'll be a merge conflict when you pull in updates.

Thank you so much @dmsnell!

This PR adds a PHP function named wp_interactivity_get_element, analogous to the getElement() function exposed in the @wordpress/interactivity JavaScript module (see ​docs).

The function is intended to be used in ​derived state props inside wp_interactivity_state, same as wp_interactivity_get_context.

For now, the returned value is an array that contains only the attributes property, which lists the originally defined attributes present in the element. That means attributes added or modified by directive processing don't appear.

Trac ticket:

Committed with https://core.trac.wordpress.org/changeset/59131