#20266 closed defect (bug) (fixed)
Update get_plugin_data()
| Reported by: | nacin | Owned by: | nacin |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.4 |
| Component: | Plugins | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Focuses: |
Description
#20103 started with taking get_plugin_data() and _get_plugin_data_markup_translate() and applying the same concept to themes. Eventually I discarded that approach, but not before I had fixed up both of these functions.
Attached is a patch.
Attachments (1)
Change History (4)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
The one issue with 20266.diff is that it causes sanitized data to be cached (as _get_plugin_data_markup_translate() is run even when $markup = $translate = false), but then will still re-sanitize the data when _get_plugin_data_markup_translate() is used later to apply markup or apply translations.
We probably need a final sanitize = false parameter, then call sanitize = true in get_plugins(). (Or true by default and false where we don't need it.) In general, these kinds of issues were what caused WP_Theme to be written.