WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 23 months ago

Last modified 23 months ago

#20270 closed defect (bug) (fixed)

Skip cached credits if version number doesn't match

Reported by: duck_ Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.2
Component: General Keywords: has-patch
Focuses: Cc:

Description

When upgrading you're redirected to wp-admin/about.php (What's New) which has the credits tab. However you may be in a situation where previously cached credits for an older version will be displayed instead of for the version you have just upgraded to.

Since the credits API returns the major version (e.g. "3.3") we can that $wp_version begins with this string.

Attachments (1)

20270.diff (650 bytes) - added by duck_ 2 years ago.

Download all attachments as: .zip

Change History (5)

duck_2 years ago

comment:1 nacin2 years ago

Might be better to key the initial transient based on $wp_version (in addition to $locale like it is already).

We really should just implement garbage collection — remove all transients on DB upgrade or core update.

comment:3 nacin23 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [20909]:

Skip cached credits if version number doesn't match. props duck_. fixes #20270.

comment:4 nacin23 months ago

  • Milestone changed from Awaiting Review to 3.4
Note: See TracTickets for help on using tickets.