WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#20281 closed defect (bug) (fixed)

Comment type filter doesn't persist across views

Reported by: duck_ Owned by: duck_
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.1
Component: Comments Keywords: has-patch
Focuses: Cc:

Description

  1. Visit edit-comments.php
  2. Filter to only show pings
  3. Switch to a different view (e.g. Approved)

Expected (as seen on 3.0.x): pings only filter to stay in effect

Actual: all comment types are displayed again

Patch attached simply globalizes $comment_type in get_views().

If this is no longer desired behaviour we can remove the dead code instead.

Attachments (1)

20281.diff (525 bytes) - added by duck_ 2 years ago.

Download all attachments as: .zip

Change History (4)

duck_2 years ago

comment:1 duck_2 years ago

Related: #16344

comment:2 duck_2 years ago

  • Owner set to duck_
  • Resolution set to fixed
  • Status changed from new to closed

In [20350]:

Make comment type filter persist across views (e.g. approved, spam) of the list of comments. Fixes #20281.

comment:3 duck_2 years ago

  • Milestone changed from Awaiting Review to 3.4
Note: See TracTickets for help on using tickets.