WP_Query implements Countable

[hakre]

Giving WP_Query the Countable interface would allow to deal with it more fluently the "PHP way".

[hakre]

Related: #20297

[GaryJ]

Although in the default compilation since PHP 5.0, until PHP 5.3 PHP can be compiled without the SPL, so it's not guaranteed to have the interface always present. I suspect that referencing a non-defined interface would cause a fatal error for those (few) that don't have the SPL compiled in PHP.

[johnbillion]

Similarly to #20297, what is the use case for this? The patch as-is achieves nothing. If WP_Query is to implement the countable interface then your patch should include the corresponding code changes which take advantage of it, otherwise the change is pointless.

[nacin]

Since SPL can be disabled, this is definitely wontfix. I will comment more on the idea in #20297.

[hakre]

Replying to GaryJ:

Although in the default compilation since PHP 5.0, until PHP 5.3 PHP can be compiled without the SPL, so it's not guaranteed to have the interface always present. I suspect that referencing a non-defined interface would cause a fatal error for those (few) that don't have the SPL compiled in PHP.

There is more in PHP that can be disabled which will break Wordpress even the minimum requirements don't show that picture. So generally this would need a review whether or not PHP is commonly compiled without the SPL. That is commonly not the case, the SPL is available everywhere by default and it's safe to expect it that way.

Replying to johnbillion:

Similarly to #20297, what is the use case for this?

The usage is obvious I'd say. See ​PHP Manual for details of the interface.

[dd32]

There is more in PHP that can be disabled which will break Wordpress even the minimum requirements don't show that picture.

Such as? Other than the MySQL extension, we've got back-compat functionality available for the (compiled by default) json and hmac components, and don't use several other default items which are often disabled.

SPL is, from memory, more commonly disabled than both the above.

[hakre]

Replying to dd32:

Such as?

For example PCRE.

SPL is, from memory, more commonly disabled than both the above.

SPL more often disabled than json? Never encountered that, but well, memory indeed can serve wrong, before introducing that a metric should be run first, good old Json has taught that lesson in the past (#16918, #18015).