WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 19 months ago

#20307 closed enhancement (maybelater)

Edit User link in admin toolbar

Reported by: johnbillion Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Toolbar Keywords: has-patch
Focuses: Cc:

Description

When you're viewing an author archive, there should be an 'Edit User' item in the admin toolbar in the same way we have 'Edit {taxonomy}' on taxonomy archives, 'Edit Post' on single posts, etc.

Attachments (3)

20307.patch (1.5 KB) - added by johnbillion 2 years ago.
14787-20307-merge.patch (6.3 KB) - added by georgestephanis 22 months ago.
20307-2.patch (668 bytes) - added by lessbloat 20 months ago.
georgestephanis code, minus "Edit My Profile"

Download all attachments as: .zip

Change History (15)

johnbillion2 years ago

comment:1 johnbillion2 years ago

  • Keywords has-patch added

Patch

Version 0, edited 2 years ago by johnbillion (next)

comment:2 nacin22 months ago

  • Milestone changed from Awaiting Review to 3.5

I could go for this. See #14787 for get_edit_user_link(), which we should definitely have.

comment:3 ryan21 months ago

In [21364]:

Introduce get_edit_user_link(). Props scribu, georgestephanis, johnbillion. fixes #14787 see #20307

comment:4 ryan21 months ago

'Edit My Profile' seems very weird, especially since there is already such a link in the account menu. And 'Edit User' seems of even less utility than the edit taxonomy menu. I guess I'm not a fan of edit menus when viewing archives.

comment:5 follow-up: johnbillion21 months ago

I agree 'Edit My Profile' is a weird one, but I added it for consistency. It can stay or go, I'm more interested in being able to edit other users when I'm on their archive pages.

An 'Edit User' link has no less utlity than an edit link on any other object page, be it a post, a taxonomy term or a user. If an object is editable in WordPress there might as well be a link to edit it whilst you're viewing it.

comment:6 in reply to: ↑ 5 DrewAPicture21 months ago

  • Cc xoodrew@… added

Replying to johnbillion:

An 'Edit User' link has no less utlity than an edit link on any other object page, be it a post, a taxonomy term or a user. If an object is editable in WordPress there might as well be a link to edit it whilst you're viewing it.

That makes good sense. +1

comment:7 follow-up: helenyhou20 months ago

What are we thinking here? Link or no?

If doing the link, let's leave it as "Edit User" whether or not it's yourself. Author archive isn't necessarily your profile, anyway.

comment:8 in reply to: ↑ 7 DrewAPicture20 months ago

It would be nice-to-have. It makes good sense that all other bundled objects seem to have an edit link in the Toolbar.

Replying to helenyhou:

If doing the link, let's leave it as "Edit User" whether or not it's yourself. Author archive isn't necessarily your profile, anyway.

Sounds good.

lessbloat20 months ago

georgestephanis code, minus "Edit My Profile"

comment:9 follow-up: ryan20 months ago

I'd still rather remove edit links for archive pages. Edit should be for specific objects only. If I were to pick an admin bar link for an author archive page it would take me to edit.php with that user's posts showing, not the user's profile.

comment:10 in reply to: ↑ 9 DrewAPicture20 months ago

Replying to ryan:

I'd still rather remove edit links for archive pages. Edit should be for specific objects only.

I'd argue in this case we have the unhappy circumstance of the author archive being both A) an archive and B) pretty much the only front-end endpoint where 'Edit User' makes sense. It's really just a matter of abstracting the logic of it. Yes, most archives shouldn't have edit links, but this one should.

comment:11 lessbloat20 months ago

Discussed in IRC: https://irclogs.wordpress.org/chanlog.php?channel=wordpress-ui&day=2012-08-29&sort=asc#m54998

Consensus was to hold off on adding an edit user link for now.

comment:12 nacin19 months ago

  • Milestone 3.5 deleted
  • Resolution set to maybelater
  • Status changed from new to closed

Going to close this as maybelater. I do mean that — maybe opinions will change.

Note: See TracTickets for help on using tickets.