Edit User link in admin toolbar

[johnbillion]

When you're viewing an author archive, there should be an 'Edit User' item in the admin toolbar in the same way we have 'Edit {taxonomy}' on taxonomy archives, 'Edit Post' on single posts, etc.

[johnbillion]

Patch (no new strings)

[nacin]

I could go for this. See #14787 for get_edit_user_link(), which we should definitely have.

[ryan]

In [21364]:

Introduce get_edit_user_link(). Props scribu, georgestephanis, johnbillion. fixes #14787 see #20307

[ryan]

'Edit My Profile' seems very weird, especially since there is already such a link in the account menu. And 'Edit User' seems of even less utility than the edit taxonomy menu. I guess I'm not a fan of edit menus when viewing archives.

[johnbillion]

I agree 'Edit My Profile' is a weird one, but I added it for consistency. It can stay or go, I'm more interested in being able to edit other users when I'm on their archive pages.

An 'Edit User' link has no less utlity than an edit link on any other object page, be it a post, a taxonomy term or a user. If an object is editable in WordPress there might as well be a link to edit it whilst you're viewing it.

[DrewAPicture]

Replying to johnbillion:

An 'Edit User' link has no less utlity than an edit link on any other object page, be it a post, a taxonomy term or a user. If an object is editable in WordPress there might as well be a link to edit it whilst you're viewing it.

That makes good sense. +1

[helenyhou]

What are we thinking here? Link or no?

If doing the link, let's leave it as "Edit User" whether or not it's yourself. Author archive isn't necessarily your profile, anyway.

[DrewAPicture]

It would be nice-to-have. It makes good sense that all other bundled objects seem to have an edit link in the Toolbar.

Replying to helenyhou:

If doing the link, let's leave it as "Edit User" whether or not it's yourself. Author archive isn't necessarily your profile, anyway.

Sounds good.

[lessbloat]

georgestephanis code, minus "Edit My Profile"

[ryan]

I'd still rather remove edit links for archive pages. Edit should be for specific objects only. If I were to pick an admin bar link for an author archive page it would take me to edit.php with that user's posts showing, not the user's profile.

[DrewAPicture]

Replying to ryan:

I'd still rather remove edit links for archive pages. Edit should be for specific objects only.

I'd argue in this case we have the unhappy circumstance of the author archive being both A) an archive and B) pretty much the only front-end endpoint where 'Edit User' makes sense. It's really just a matter of abstracting the logic of it. Yes, most archives shouldn't have edit links, but this one should.

[lessbloat]

Discussed in IRC: ​https://irclogs.wordpress.org/chanlog.php?channel=wordpress-ui&day=2012-08-29&sort=asc#m54998

Consensus was to hold off on adding an edit user link for now.

[nacin]

Going to close this as maybelater. I do mean that — maybe opinions will change.

[johnbillion]

I'd like to get this in in conjunction with #38085.

[johnbillion]

20307.2.patch​ adds an Edit User link on the front end, and a corresponding View user link on the user editing screen.

[chriscct7]

Should this use get_current_user_id() instead of the user_id global?

[johnbillion]

Nope because the edit link is for whichever author archive you're viewing -- not the current logged in user.

[desrosj]

Relate #38085

[johnjamesjacoby]

20307.2.patch looks OK to me.

[johnbillion]

In 41159:

Toolbar: Add View User and Edit User links to the admin toolbar to ease navigation between a user's archives and the user editing screen.

Props georgestephanis, lessbloat, johnbillion

Fixes #20307