Opening Double Quote after 3 hyphens converted to double closing quote

[PetesGuide]

The string:

<p>I also remember the line in "Casey at the Bat" when he struck out---"There is no Joy in Mudville!!!"</p>

is converted to this in WordPress 3.3.1:

<p>I also remember the line in &#8220;Casey at the Bat&#8221; when he struck out&#8212;&#8221;There is no Joy in Mudville!!!&#8221;</p>

Seems to be what should be an opening quote that follows an Em dash is always converted into a closing quote.

[nacin]

Sorry for you never hearing anything, PetesGuide. This sounds like a lot of other wptexturize tickets. (full list). If a contributor can supply a unit test for this, we'll be in good shape to going forward with possible fixed.

[cmmarslender]

Unit Test

[adamsilverstein]

opening double quote, even after -

[adamsilverstein]

correct space inadvertantly added to unit test

[adamsilverstein]

don't breat other tests!

[adamsilverstein]

20342.4.diff​ adds ';' to the list of characters after which a double quote (and single quote) is replaced with unicode equivalent. Previous attempts broke other unit test in formatting, verified this change does not break any other tests while resolving the test case in this ticket.

[miqrogroove]

This patch would fix <"Test Quote"> which is currently broken.

It would also break things like Then he said, "Try using the &"

[adamsilverstein]

corrected extra space

[adamsilverstein]

Replying to miqrogroove:

This patch would fix <"Test Quote"> which is currently broken.

It would also break things like Then he said, "Try using the &"

Thanks for the feedback.

I tried testing these two strings via a unit test in 20342-tests.2.diff​ and don't see how the patch effects them. What were you expecting from wp_texturize and what are your results, before and after the patch?

[miqrogroove]

I'm using those as editor inputs on the Visual tab. They are converted to HTML before wptexturize(). If I had to trade off quotes ending with & for quotes wrapped in angle braces, I would be in favor. Both seem trivial to me.

[miqrogroove]

Perhaps the larger concern is that including the semi-colon arbitrarily could have unwanted results on non-UTF-8 websites. That would be a question for the staff to tackle.

[miqrogroove]

Note the patch for #23185 will put hyphen conversion at the end of wptexturize, so we can consider simply allowing hyphens before quotes. This will work as long as we never expect input like, "This is my weird quote-"

[miqrogroove]

#23185 is fixed now, so this will be much easier. Patch is attached.

[wonderboymusic]

In 28726:

In wptexturize(), allow dashes before and after curly quotes. Example: This is what she said---"Wow that is cool."

Adds unit tests.

Props adamsilverstein, miqrogroove.
Fixes #20342.