Filter image_hwstring()

[wpsmith]

Make it possible to remove width and height from media HTML output functions by filtering image_hwstring(). This is perfect for responsiveness.

This can be done a few different ways:

function image_hwstring($width, $height) {
	$out = '';
	if ($width)
		$out .= 'width="'.intval($width).'" ';
	if ($height)
		$out .= 'height="'.intval($height).'" ';
	return apply_filters( 'image_hwstring', $out );
}

This could be easily filtered by something like:

add_filter( 'image_hwstring', '__return_empty_string' );

See #20357.

[nacin]

I think image_hwstring() is too low level for this, as it is but a helper.

Instead, we should push 'height' and 'width' into the attributes in wp_get_attachment_image(), which will force them through the wp_get_attachment_image_attributes filter. There is a duplicate ticket covering thid.

[nacin]

#14110

[SergeyBiryukov]

#22285 was marked as a duplicate.

[Cibulka]

Hardcoded image dimmensions, that can't be manipulated in any way - this is the biggest WTF I have with WordPress. Is there ANY reason, why image_hwstring exists? Or why it can't be filtered?

Also, why is this issue closed?

[johnbillion]

This is a duplicate of #14110 which has had no feedback in three years.

CSS rules for width and height override the width and height attributes on the img element.

[Cibulka]

Thanks for the quick reply!

CSS can override this, but don't you agree it's a little bit silly to fix incorrect output with CSS? Wouldn't be easier to simply make this function filterable?

I'm not the lonely head scratcher here:

• ​https://wordpress.stackexchange.com/questions/29881/stop-wordpress-from-hardcoding-img-width-and-height-attributes
• ​https://wordpress.stackexchange.com/questions/22302/how-do-you-remove-hard-coded-thumbnail-image-dimensions
• ​https://wordpress.stackexchange.com/questions/5568/filter-to-remove-image-dimension-attributes
• ​https://gist.github.com/stuntbox/4557917 (59 stars)
• ​https://wpbeaches.com/responsively-removing-width-and-height-attributes-in-images-on-wordpress/
• ​http://wpcrux.com/blog/remove-image-attachment-dimensions/

... and many, many more.

I've ended up with very complex filtering of image_downsize function: ​https://gist.github.com/cibulka/8e2bf16b0f55779af590472ae1bf9239

The gist of the sollution is to remove image dimmensions from image_downsize function, as it is the only way (!!!) how to influence image_hwstring.

One of many side effects of this sollutions is that wp_get_attachment_src obviously stops returning image dimmensions - so for this functionality I needed to create my own function.

Wouldn't is just be easier to make a filter? :)

[dd32]

I'm going to re-close this as a duplicate of #14110.

If you feel strongly about having it filtered, please re-open that main ticket, as it's where all discussion has been re-routedd to.

Please don't re-open this ticket because you want a filter, please take it to #14110.