WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#20378 closed defect (bug) (fixed)

get_theme_updates() assumes update data is present (regression)

Reported by: johnbillion Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.4
Component: Upgrade/Install Keywords: has-patch commit
Focuses: Cc:

Description

Changes made to get_theme_updates() as part of #20103 mean it now assumes that theme update data is present in the 'update_themes' transient.

If theme updates have been disabled then this data is not present and a PHP warning is triggered when you view the WordPress Updates screen.

Attachments (1)

20378.patch (732 bytes) - added by johnbillion 2 years ago.

Download all attachments as: .zip

Change History (5)

johnbillion2 years ago

comment:1 johnbillion2 years ago

  • Keywords has-patch added

Patch

comment:2 nacin2 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.4

We should probably double-check other transient calls to ensure this is consistent.

comment:3 nacin2 years ago

Looks good.

comment:4 nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [20438]:

Check if the response property is set before continuing with the update_themes transient return value. props johnbillion, fixes #20378.

Note: See TracTickets for help on using tickets.