/2012/03/individual-post/?page=2 canonical redirects not properly handled

[markjaquith]

Multipage posts don't have their ?page=X parameter properly redirected to a /X/ URL.

[markjaquith]

In [20397]:

Properly handle paged permalink URLs even when we are not already 301ing. fixes #20385

[batmoo]

This breaks pagination on sites with static front pages: ​http://example.com/page/2/ gets redirected to ​http://example.com/2/

Adding a front page check seems to fix that:

if ( is_singular() && ! is_front_page() && get_query_var('page') ) {

[markjaquith]

I'll work on this tonight. Needs unit tests!

[ryan]

In [20444]:

Don't do a canonical redirect for singular paged pages when on the front-page. This was breaking pagination on sites with a static home page. Props batmoo. see #20385

[markjaquith]

Okay, I tried. But our canonical redirect unit tests appear to be fundamentally broken. They simulate an HTTP request. Poorly. I couldn't get the test to fail, even at [20443].

[markjaquith]

Sigh. Nevermind. Figured it out. Stupid typo. Made a unit test for it. The fix is good.

​http://unit-tests.trac.wordpress.org/changeset/669/