Opened 13 years ago
Last modified 5 years ago
#20386 new defect (bug)
Year permalinks "win" against category permalinks
Reported by: | markjaquith | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Canonical | Keywords: | needs-patch needs-unit-tests |
Focuses: | Cc: |
Description
We need to decide whether category permalinks should take priority over year permalinks.
e.g. /2008/?category_name=cat-a
Should that stay the same, or redirect to:
/category/cat-a/?year=2008
We have a unit test which is failing.
Attachments (1)
Change History (7)
#4
@
12 years ago
IMO, canonical URL should always win over query string, and both always win over tax_query.
I addressed the problem with tax_query winning here: #20767
Right now, tax is beating tag and category, which to me makes no sense because tax_query is a sub-request. Query string terms get tax=term treatment in WP_Query but are really only altering context of the request, not completely changing it.
Precedence really only affects theme functions since is_year, is_category will both be true and the year and category are publicly available in the request. Whoever "wins" gets precedence in which template is picked or which title is displayed, etc.
We've had somewhat similar prioritization issues where this has come up for post types versus taxonomies.
I think it should go like this: post types > taxonomies > date filters.