WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#20404 closed task (blessed) (fixed)

Use theme customizer instead of thickbox theme preview

Reported by: koopersmith Owned by: koopersmith
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.4
Component: Administration Keywords:
Focuses: Cc:

Description

The now old-school thickbox theme previewer is still used on the theme install/update screens. We should use the new customizer instead and completely deprecate theme-preview.js.

Attachments (1)

20404.diff (13.5 KB) - added by koopersmith 2 years ago.

Download all attachments as: .zip

Change History (6)

koopersmith2 years ago

comment:1 koopersmith2 years ago

  • Status changed from new to accepted

The attached patch replaces all remaining instances of the thickbox theme previewer. It also separates the inclusion of the customize loader from the WP_Customize class. The loader is just a container that requires a JS file and a small amount of markup.

comment:2 nacin2 years ago

Looks good.

comment:3 follow-up: dd322 years ago

Just a fly-by: Make sure you test the Bulk update as well as singular update, the bulk update runs through a iframe, whereas the latter doesn't.

comment:4 in reply to: ↑ 3 koopersmith2 years ago

Replying to dd32:

Just a fly-by: Make sure you test the Bulk update as well as singular update, the bulk update runs through a iframe, whereas the latter doesn't.

Yep, I tested bulk update — works for me. :)

comment:5 koopersmith2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [20419]:

Replace all instances of thickbox theme preview with the theme customizer. fixes #20404.

  • Use theme customizer in theme install/update screens.
  • Separate the customize loader from the customizer. Use wp_customize_loader() to include the loader script and markup.
  • Deprecated: wp-admin/js/theme-preview.js is now no longer used by core.
Note: See TracTickets for help on using tickets.