XML-RPC returns only full-size URL for featured image

[koke]

I'm not sure if having more than one featured_image url would be too much for getPost (and similar calls), since there are also media library calls, but if there's going to be any, maybe the thumbnail size url would be more relevant

[nacin]

Indeed, it would make more sense if only the thumbnail size was returned.

We don't yet have get_the_post_thumbnail_src() yet — #11571. But we can simply call wp_get_attachment_image() with $size = 'post-thumbnail'.

[markoheijnen]

What about wp_get_attachment_thumb_url(). Seems like in this case that should work to.

That said wp_get_attachment_image() is a better way since it also can give the possibility to change the size when needed. Maybe not know but for future possibilities.

[maxcutler]

Another alternative is to extract most of wp_getMediaItem into a _prepare_media_item method and use that for featured_image in _prepare_post instead of an ID and a separate additional field.

That way you would have wp_getMediaItem, wp_getMediaLibrary, and _prepare_post all returning image/attachment data in an identical and filter-able format. And you'd solve the re-querying performance hit with wp_getMediaLibrary.

We are already doing this for terms in _prepare_post.

If others like this, I can draw up a patch and unit tests tonight.

[markoheijnen]

That does make sense to me.

[nacin]

Sure. It's worth mentioning that wp_get_attachment_thumb_url() uses a size of 'thumbnail' while post thumbnails are a particular 'post-thumbnail' size. So you still may need to use wp_get_attachment_image() with a $size.

[maxcutler]

Added a patch for my suggestion above. Now posts will have a post_thumbnail field which is an array containing the same values as would be gotten from wp.getMediaItem (or an empty array if there's no thumbnail).

As suggested by nacin, the thumbnail URL will use 'post-thumbnail' size if the theme supports it, and fall back to 'thumbnail' otherwise.

Also added basic tests in ​[UT693] to cover the existing wp.getMediaItem/wp.getMediaLibrary behavior so that we don't break that.

[ryan]

I think we can drop the extra underscore from the xmlrpc__prepare_media_item filter.

[maxcutler]

Refreshed patch after comments in IRC:

• Replaced get_post_meta calls with get_post_thumbnail_id
• Removed 'wp_post_thumbnail_url' from the legacy methods.
• Replaced one-line if statement with a ternary statement.

Will create another ticket for the extra underscores that ryan mentioned.

[ryan]

In [20608]:

XML-RPC featured image and media preparation cleanup.

• Introduce _prepare_media_item().
• Use it to prepare post_thumbnail info in _prepare_post().
• Also use _prepare_media_item() in wp_getMediaLibrary() and wp_getMediaItem() so that all media is prepared consistently and uses the same filters.

Props maxcutler
Fixes #20409

[ryan]

post-thumbnail-template.php is conditionally loaded based upon whether the theme supports post-thumbnails. If the theme does not, get_post_thumbnail_id() is undefined and results in fatal errors.

[ryan]

We can either always load post-thumbnail-template.php or move get_post_thumbnail_id() and perhaps has_post_thumbnail() to post.php.

[markoheijnen]

I would prefer moving get_post_thumbnail_id. Would make sense since updating and removing can be done when theme doesn't supports post-thumbnails

[ryan]

I'm leaning that way myself. Anyone want to patch it up and test? Perhaps we could cajole the unit tests into running with and without post-thumbnail support enabled.

[ryan]

​[UT699]

[ryan]

Move functions

[markjaquith]

post-thumbnail-template.php is so tiny... there honestly can't be any benefit to having it loaded conditionally. It's five function definitions.

[nacin]

In [20610]:

Deprecate require_if_theme_supports(). Always require post-thumbnail-template.php. fixes #20556. fixes #20409.