Make WordPress Core

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#20418 closed defect (bug) (fixed)

make_clickable() should not operate on links in attributes.

Reported by: ryan Owned by: ryan
Priority: normal Milestone: 3.4
Component: Formatting Version: 3.3.1
Severity: normal Keywords:
Cc: Focuses:

Description

make_clickable() turns this:

<a href="http://example.com/example.gif" title="Image from http://example.com">Look at this image!</a>

into this:

<a href="http://example.com/example.gif" title="Image from <a href="http://example.com" rel="nofollow">http://example.com</a>">Look at this image!</a>

It should not.

Attachments (2)

20418.diff​ (5.0 KB ) - added by ryan 15 years ago.
20418-unit-tests.diff​ (4.6 KB ) - added by ryan 15 years ago.

Download all attachments as: .zip

Change History (5)

@ryan
15 years ago

#1 @ryan
15 years ago

  • Owner set to ryan
  • Resolution → fixed
  • Status new → closed

In [20443]:

Don't attempt to make links inside attributes clickable. Props duck_ azaozz. fixes #20418

#3 @nacin
15 years ago

Looks good, tests well.

Note: See TracTickets for help on using tickets.