WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#20418 closed defect (bug) (fixed)

make_clickable() should not operate on links in attributes.

Reported by: ryan Owned by: ryan
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.3.1
Component: Formatting Keywords:
Focuses: Cc:

Description

make_clickable() turns this:

<a href="http://example.com/example.gif" title="Image from http://example.com">Look at this image!</a>

into this:

<a href="http://example.com/example.gif" title="Image from <a href="http://example.com" rel="nofollow">http://example.com</a>">Look at this image!</a>

It should not.

Attachments (2)

20418.diff (5.0 KB) - added by ryan 2 years ago.
20418-unit-tests.diff (4.6 KB) - added by ryan 2 years ago.

Download all attachments as: .zip

Change History (5)

ryan2 years ago

ryan2 years ago

comment:1 ryan2 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [20443]:

Don't attempt to make links inside attributes clickable. Props duck_ azaozz. fixes #20418

comment:3 nacin2 years ago

Looks good, tests well.

Note: See TracTickets for help on using tickets.