WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#20427 closed enhancement (fixed)

Remove unused _insert_into_post_button() function

Reported by: SergeyBiryukov Owned by: ryan
Priority: normal Milestone: 3.5
Component: Media Version: 3.3
Severity: normal Keywords: has-patch needs-refresh
Cc: Focuses:

Description

_insert_into_post_button() is no longer used in core since [18831].

It's a private function which doesn't seem to be used in any plugins, so I guess it can be removed without deprecation.

Attachments (1)

20427.patch​ (836 bytes ) - added by SergeyBiryukov 14 years ago.

Download all attachments as: .zip

Change History (6)

@SergeyBiryukov
14 years ago

#1 @SergeyBiryukov
14 years ago

Searching through the plugins repository gives 6 results:

advanced-code-editor/js/complete.js
codemirror-for-codeeditor/codemirror/lib/util/javascript-hint.js
my-shortcodes/codemirror/lib/util/javascript-hint.js
presstest/mocked/core.php
wpide/js/autocomplete.wordpress.js
wpide/js/html-tags.js

Mostly code highlighters, it doesn't look like any of them would break.

If removing the function is still too risky, we could deprecate it just in case.

#2 @nacin
14 years ago

I had left it there as-is originally in case anyone was using it. We can probably empty and deprecate it.

#4 @nacin
14 years ago

  • Keywords needs-refresh added
  • Milestone Awaiting Review → 3.5

Let's put it in admin/includes/deprecated.php as a stub.

#5 @ryan
14 years ago

  • Owner set to ryan
  • Resolution → fixed
  • Status new → closed

In [21352]:

Deprecate and stub _insert_into_post_button(). fixes #20427

Note: See TracTickets for help on using tickets.