Don't update last_updated when deleting non-published posts

[ryan]

add_action( 'delete_post', 'wpmu_update_blogs_date' );

Instead of that, let's hook in an action that checks the post status and updates only when published posts are deleted. This will avoid lots of updates to wp_blogs when cleaning out old auto-draft posts.

Inspired by #19663. [20440] caused massive numbers of updates to wp_blogs.

[nacin]

We can probably re-purpose what went in for [19129].

[SergeyBiryukov]

Just removing the action seems enough. _update_blog_date_on_post_publish() handles the rest.

[azaozz]

Perhaps also bypass it when deleting trashed posts. Form the user's point of view they are long gone and nothing has changed.

[ryan]

Just removing the action will work fine for trashed posted that are later deleted as_update_blog_date_on_post_publish() will indeed handle things. But, it won't work for forced deletions. We don't care about the auto-draft forced deletions, but are there forced deletes we should care about?

[SergeyBiryukov]

20433.2.patch​ introduces _update_blog_date_on_post_delete().

[ryan]

In [20461]:

Don't update a blog's last_updated time for all post deletions. Update only when published posts are deleted.

Props SergeyBiryukov
fixes #20433