WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 2 months ago

#20438 closed defect (bug) (invalid)

Custom Post Types with Post Format support aren't registered against post_format taxonomy

Reported by: batmoo Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords:
Focuses: Cc:

Description

When a custom post type adds support for post-formats, this doesn't actually register the post_format taxonomy for the post_type.

Here's a quick test:

add_action( 'init', function() {
        register_post_type( 'not-post', array( 'supports' => 'post-formats' ) );
        global $wp_taxonomies;
        var_dump( 'post supports post_format:', in_array( 'post', $wp_taxonomies[ 'post_format' ]->object_type ) );
        var_dump( 'not-post supports post_format:', in_array( 'not-post', $wp_taxonomies[ 'post_format' ]->object_type ) );
} );

The post_format taxonomy doesn't get returned when get_object_taxonomies is called for the custom post type and one side-effect of this is that the post_format_relationships cache does not get flushed by clean_object_term_cache leading to stale values when a post format is changed.

(The post post_type is immune to this because core registers the post_format taxonomy with it.)

When a post_type adds support for post-formats, an explicit association should be made between the post_type and the post_format taxonomy.

Change History (17)

#1 @danielbachhuber
5 years ago

  • Cc wordpress@… added

#2 @saracannon
5 years ago

  • Cc sararcannon@… added

#3 @nacin
5 years ago

If you are going to add UI support for post formats, you should just add the object type to the taxonomy as well.

So:

add_post_type_support( 'page', 'post-formats' );
register_taxonomy_for_object_type( 'post_format', 'page' );

We discussed this in 3.1. Given that using post formats for something other than posts is generally not going to be a good idea (or at least a very uncommon one), I certainly think two lines is just fine, rather than one plus doing something to unnecessarily automate this in core.

Last edited 15 months ago by DrewAPicture (previous) (diff)

#4 @nacin
5 years ago

  • Keywords close added

#6 @iseulde
3 years ago

  • Component changed from General to Post Types

#7 @danielbachhuber
3 years ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

#8 @chriscct7
19 months ago

#32385 was marked as a duplicate.

#9 @chriscct7
19 months ago

#31394 was marked as a duplicate.

#10 @chriscct7
19 months ago

#32385 was marked as a duplicate.

#11 follow-up: @s0what
15 months ago

  • Version set to 4.1.3

adding

register_taxonomy_for_object_type( 'post-format', 'page' );

doesn't work for me, nor does replacing 'post-format' with 'post-formats' or 'post_format' and 'post_formats'.

#12 in reply to: ↑ 11 @DrewAPicture
15 months ago

Replying to s0what:

adding

register_taxonomy_for_object_type( 'post-format', 'page' );

doesn't work for me, nor does replacing 'post-format' with 'post-formats' or 'post_format' and 'post_formats'.

@nacin's example in comment:3 had a typo. The slug for the post formats taxonomy is post_format not post-format.

This should work for you:

register_taxonomy_for_object_type( 'post_format', 'page' );

#13 @DrewAPicture
15 months ago

  • Version 4.1.3 deleted

#14 @s0what
15 months ago

Thanks for the quick replay, but it does not help. I still get 404 page.

#15 @Arcath
2 months ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

I am still getting this error.

<?php
register_taxonomy_for_object_type('post_format', 'page');

Has not fixed the problem

Running

<?php
print_r(get_object_taxonomies('page'));

proves that the taxonomy has been registered on pages but I still get the 404 for previews.

#16 @Arcath
2 months ago

Never mind I found the solution.

I have updated the wiki with the solution. https://codex.wordpress.org/Post_Formats#Adding_Post_Type_Support

#17 @Arcath
2 months ago

  • Resolution set to invalid
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.