wp_delete_user( int, $user_id ) does not flush post caches

[joehoyle]

Calling wp_delete_post( 2456, 1 ) does not flush the caches for the re-assigned posts. For example:

// assuming post 123 has an author of 2
$post = get_post( 123 );

wp_delete_user( $post->post_author, 1 );

$post = get_post( 123 );
$post->post_author; // this is "2", should be "1"

This is because clean_post_cache is not called on the reassigned posts (see ​http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/user.php#L259).

The best way around this I can see is get the post IDs and called wp_update_post() to let code hook in to update stuff where necessary. If performance is an issue (s wp_update_post can be slow), then I think it should at least get all the post IDs and call clean_post_cache on them.

[scribu]

Should definitely use wp_update_post() instead of just $wpdb->update().

[kurtpayne]

Use wp_update_post and wp_update_link

[nacin]

Definitely not new — setting to an earlier version.

[nacin]

​[UT997]

[nacin]

Not sure I'd mind if we just clear the post cache here, rather than switching to use the API. That's a painful update to run across a lot of posts individually.

[kurtpayne]

Using clean_post_cache and clean_bookmark_cache

[kurtpayne]

Replying to nacin:

Not sure I'd mind if we just clear the post cache here, rather than switching to use the API. That's a painful update to run across a lot of posts individually.

Agreed. Patch updated.

[ryan]

In [21798]:

When reassigning posts and links during user deletion, clear the post and link caches. Props kurtpayne. fixes #20447