Media screen links to non-public post types

[johnbillion]

I have a non-public custom post type registered, so it doesn't get an admin UI.

A file in the media library is attached to one of my custom posts (done at the point the file is uploaded using media_handle_upload()). The media item shows up in the Media Library as expected, but the 'Attached To' column links to the editing screen for the parent post, even though the post is non-public.

This allows a user to see the post editing screen for a non-public post type.

[johnbillion]

Attached is my patch. I fully expect this to have side effects, so this needs input from others.

Additionally, the existing logic which checks the return value of get_post() on line 298 looks erroneous to me. If it returns false then the $title variable is not going to be as expected.

[nacin]

Given your patch, by non-public, I assume you mean non-show_ui. In that case, patch looks good.

[johnbillion]

Refreshed patch

[nacin]

In 25140:

Don't create an edit link to a non-UI post type in the media list table.

props johnbillion.
fixes #20453.