Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#20466 closed enhancement (fixed)

jQuery UI 1.8.19

Reported by: ocean90's profile ocean90 Owned by: nacin's profile nacin
Milestone: 3.4 Priority: normal
Severity: major Version:
Component: External Libraries Keywords: has-patch
Focuses: Cc:


Nacin noticed an update for jQuery UI.

Release post:


Attachments (2)

20466.part1.patch (229.1 KB) - added by ocean90 12 years ago.
20466.part2.patch (198.1 KB) - added by ocean90 12 years ago.

Download all attachments as: .zip

Change History (11)

#1 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [20492]:

jQuery UI 1.8.19. props ocean90. fixes #20466.

#2 @Ipstenu
12 years ago

  • Keywords needs-refresh added
  • Resolution fixed deleted
  • Severity changed from normal to major
  • Status changed from closed to reopened

This breaks Drag & Drop in all sections of WordPress.

I just spun up a fresh site and I can't drag/drop on the main dash or any widgets, on Chrome or IE 7 (I know, but still).

I rolled back the js stuff and it all worked again.

No plugins, nothing on the site.

#3 @ocean90
12 years ago

Which OS, which Chrome version? Any Javascript errors?

#4 @Ipstenu
12 years ago

Also breaks media insert. Fun!

Windows XP, Chrome 19.0.1084.24 beta-m

All I see in the Chrome Console is "Uncaught TypeError: undefined is not a function" for load-scripts.php but I've not really poked the console that much. I follow directions like a boss :)

#5 @ocean90
12 years ago

Cool down please.

It's an issue with script concatenation.

Add define('CONCATENATE_SCRIPTS', false); to your wp-config.php file and it should work again.

Last edited 12 years ago by ocean90 (previous) (diff)

#6 @Ipstenu
12 years ago

I'm not upset at all :D Highly amused. Otherwise why am I running aortic ;)

That gets it working again.

#7 @ocean90
12 years ago

  • Keywords needs-refresh removed

nacin: azaozz: ocean90: I'm handling the jQuery UI things, thanks for that.

azaozz: nacin: seems all jQuery minified files are missing a semicolon at the end, perhaps ping them too?

nacin: already on it

azaozz: great

#8 @nacin
12 years ago

In 1.8.17, jQuery UI switched from closure compiler to uglify.js, which removes the final semicolon from the file.

This was a quirk of the library and was not intentional. In 1.8.20 they will be restoring the semicolon in the build process: For now we are going to manually restore them.

#9 @nacin
12 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [20494]:

Restore semicolons to the end of jQuery UI files, as they are needed when concatenating the files together. Will be adjusted upstream as well. props ocean90. fixes #20466.

Note: See TracTickets for help on using tickets.