Opened 13 years ago
Closed 12 years ago
#20502 closed defect (bug) (fixed)
Admin menu glitch with pending comments count bubble
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.5 | Priority: | low |
Severity: | normal | Version: | 3.2 |
Component: | UI | Keywords: | has-patch commit |
Focuses: | Cc: |
Attachments (10)
Change History (24)
#3
@
13 years ago
- Owner set to azaozz
- Resolution set to fixed
- Status changed from new to closed
In [21283]:
#4
@
13 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
This is still an issue on hover due to .menu-top:hover .wp-menu-arrow
having z-index
of 1001:
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/css/wp-admin.dev.css#L1506
#5
@
13 years ago
Shouldn't we create some kind of guidelines for the value of z-index. Having the need of a z-index of 1000 seems weird to me
#8
@
13 years ago
I don't know if we can really define a hard guideline/rule for z-index values, but we should definitely be making and reviewing patches that involve z-index without inflating the values too much. 1000 for a z-index isn't uncommon, though, especially if you're potentially competing with plugin/theme-added CSS.
#9
@
13 years ago
I don't know it either but I'm just curious if we can. A z-index of 1000 is default for the jQuery dialog. So given a z-index of 1500 to the count bubble will make this look weird. You can fix this with setting a higher z-index for the dialog. At that point no matter what, you are potentially competing with other CSS code.
Another reason I asked was because of the hugh z-index on the adminbar (99999).
#10
@
13 years ago
Seems that a high z-index on li.menu-top:hover .wp-menu-arrow
is needed to correspond with the one on .wp-submenu
, which is 999:
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/css/wp-admin.dev.css#L1327
However 20502.2.patch would cause the same issue as in #20300.
Here's another idea: since z-index only makes the difference here when there's a submenu, 20502.3.patch adds .wp-has-submenu
to the related selectors.
#11
@
13 years ago
- Keywords ui-feedback removed
I tested this. The patch looks good.
#13
@
12 years ago
[21574] fixed the hover bubble glitch (20502.hover.before.png).
However, there's another glitch now:
- Go to "Posts" screen.
- Click "Comments" menu item.
- The arrow briefly appears (20502.arrow.png) and disappears again before the page opens.
- If "Comments" is focused by tabbing (or by clicking it and moving the cursor away from the item while the mouse button is still pressed), the arrow persists. It looks unnecessary there, since "Comments" item doesn't have a submenu.
20502.4.patch fixes that.
20502.5.patch also reorders the rules to more closely match the block in line 1543.
Looks better in Russian version as well (attachment:20502.after.png).