WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#20515 closed task (blessed) (fixed)

3.4 Theme-related Help Tabs

Reported by: TomAuger Owned by: ryan
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.4
Component: Help/About Keywords: has-patch
Focuses: Cc:

Description

I've written the new Help Tabs for the revised Appearance > Themes pages. Included is a new tab for the Theme Previewer / Customizer, and a new tab for Installing / Previewing from the Install Themes page.

Attachments (2)

3.4_Theme_Help_Tabs.patch (7.0 KB) - added by TomAuger 2 years ago.
3.4_Theme_Help_Tabs-root.patch (6.7 KB) - added by TomAuger 2 years ago.
Still getting used to SVN. Here's a root-relative patch

Download all attachments as: .zip

Change History (8)

comment:1 dougwrites2 years ago

How about getting rid of the quote marks for describing words/phrases/actions that are in the interface? Customize instead of "Customize"

We are still doing this without a Style Guide for the help tabs, but this would make it consistent with how we've done the other tabs.

comment:2 dougwrites2 years ago

  • Cc heymrpro@… added

comment:3 ocean902 years ago

  • Milestone changed from Awaiting Review to 3.4

Could you change your patch to include relative paths from the WordPress root dir, please?

comment:4 TomAuger2 years ago

Hi Doug, thanks for the feedback. I deliberately quote UI items for consistency. If the UI item is labelled "Customize", I can see not quoting it, as the capital letter and the single word help to disambiguate it. However, a number of these UI items are links in mixed or sentence case and could seriously confuse a sentence in which they are found. Hence, the quotes. I think it is a best practice to which the help tabs should eventually all adhere.

Last edited 2 years ago by TomAuger (previous) (diff)

TomAuger2 years ago

Still getting used to SVN. Here's a root-relative patch

comment:5 nacin2 years ago

  • Component changed from Themes to Help/About

comment:6 ryan2 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [20736]:

Contextual help updates for themes.php and theme-install.php. Props TomAuger. fixes #20515

Note: See TracTickets for help on using tickets.