WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#20518 closed task (blessed) (fixed)

3.4 Help Tabs - Appearance > Header

Reported by: TomAuger Owned by: duck_
Priority: normal Milestone: 3.4
Component: Help/About Version: 3.4
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

Not sure whether I should be creating a new ticket or attaching the patch to some existing ticket. At any rate, here is the help tabs for the Appearance > Header page.

Note that this doesn't mention flex headers because that doesn't seem to be available in my version from trunk (updated as of today). I'll try to apply the latest patch from #17242 and see whether that changes anything and update the help tab if it does.

Attachments (3)

3.4_CustomHeader_Help_Tabs.patch​ (3.7 KB ) - added by TomAuger 14 years ago.
3.4_CustomHeader_Help_Tabs-root.patch​ (3.3 KB ) - added by TomAuger 14 years ago.
Still new to creating SVN patches. This one should be from the root folder now.
20518-typo.diff​ (1.8 KB ) - added by klagraff 14 years ago.

Download all attachments as: .zip

Change History (13)

@TomAuger
14 years ago

#1 @ocean90
14 years ago

  • Component Administration → Themes
  • Milestone Awaiting Review → 3.4

With #20448 Twenty Ten and Twenty Elven are supporting flex heights. So it should be available.

#2 @TomAuger
14 years ago

I was expecting something to change in the UI. I don't think anything needs to change in the help text.

@TomAuger
14 years ago

Still new to creating SVN patches. This one should be from the root folder now.

#3 @nacin
14 years ago

  • Component Themes → Help/About

#4 @ryan
14 years ago

In [20718]:

Custom header contextual help updates. Props TomAuger. see #20518

#5 @ryan
14 years ago

In [20719]:

Don't concatenate translated strings. see #20518

#6 @ryan
14 years ago

  • Resolution → fixed
  • Status new → closed

@klagraff
14 years ago

#7 @klagraff
14 years ago

  • Resolution fixed
  • Status closed → reopened

Realized there was a typo introduced in [20718]. 20518-typo.diff fixes it.

#8 @SergeyBiryukov
14 years ago

  • Keywords commit added

#9 @tomauger
14 years ago

@klagraff thanks for the catch!

#10 @duck_
14 years ago

  • Owner set to duck_
  • Resolution → fixed
  • Status reopened → closed

In [20768]:

Fix typo in Custom Header contextual help. Props klagraff. Fixes #20518.

Note: See TracTickets for help on using tickets.