WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#20518 closed task (blessed) (fixed)

3.4 Help Tabs - Appearance > Header

Reported by: TomAuger Owned by: duck_
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.4
Component: Help/About Keywords: has-patch commit
Focuses: Cc:

Description

Not sure whether I should be creating a new ticket or attaching the patch to some existing ticket. At any rate, here is the help tabs for the Appearance > Header page.

Note that this doesn't mention flex headers because that doesn't seem to be available in my version from trunk (updated as of today). I'll try to apply the latest patch from #17242 and see whether that changes anything and update the help tab if it does.

Attachments (3)

3.4_CustomHeader_Help_Tabs.patch (3.7 KB) - added by TomAuger 2 years ago.
3.4_CustomHeader_Help_Tabs-root.patch (3.3 KB) - added by TomAuger 2 years ago.
Still new to creating SVN patches. This one should be from the root folder now.
20518-typo.diff (1.8 KB) - added by klagraff 2 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 ocean902 years ago

  • Component changed from Administration to Themes
  • Milestone changed from Awaiting Review to 3.4

With #20448 Twenty Ten and Twenty Elven are supporting flex heights. So it should be available.

comment:2 TomAuger2 years ago

I was expecting something to change in the UI. I don't think anything needs to change in the help text.

TomAuger2 years ago

Still new to creating SVN patches. This one should be from the root folder now.

comment:3 nacin2 years ago

  • Component changed from Themes to Help/About

comment:4 ryan2 years ago

In [20718]:

Custom header contextual help updates. Props TomAuger. see #20518

comment:5 ryan2 years ago

In [20719]:

Don't concatenate translated strings. see #20518

comment:6 ryan2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

klagraff2 years ago

comment:7 klagraff2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Realized there was a typo introduced in [20718]. 20518-typo.diff fixes it.

comment:8 SergeyBiryukov2 years ago

  • Keywords commit added

comment:9 tomauger2 years ago

@klagraff thanks for the catch!

comment:10 duck_2 years ago

  • Owner set to duck_
  • Resolution set to fixed
  • Status changed from reopened to closed

In [20768]:

Fix typo in Custom Header contextual help. Props klagraff. Fixes #20518.

Note: See TracTickets for help on using tickets.