PHP Notice in get_single_template()

[markjaquith]

PHP Notice: Trying to get property of non-object in wp-includes/template.php on line 283

These get_*_template() functions make a lot of assumptions about the current state of the environment.

[SergeyBiryukov]

Related: #17662, #18614

[wonderboymusic]

This patch has basic validation for the passing of vars to template file names

[nacin]

I think in most cases it should be enough to validate we have an object. So rather than:

if ( isset( $author->user_nicename ) )
 	$templates[] = "author-{$author->user_nicename}.php";
if ( isset( $author->ID ) )
        $templates[] = "author-{$author->ID}.php";

We can do:

if ( $author ) {
 	$templates[] = "author-{$author->user_nicename}.php";
        $templates[] = "author-{$author->ID}.php";
}

[ryan]

In [22293]:

Avoid notices in get_*_template() functions that use get_queried_object(), which can return null. Props wonderboymusic. fixes #20519

[chriscct7]

I believe this still happens, and I opened a new ticket here on it: ​http://core.trac.wordpress.org/ticket/25398