Make WordPress Core

Opened 14 years ago

Closed 12 years ago

#20545 closed defect (bug) (worksforme)

TinyMCE - Edit/Delete Image Buttons Show For Non-editable Items

Reported by: master-jake's profile Master Jake Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.3.1
Component: TinyMCE Keywords:
Focuses: Cc:

Description

Forgive me if this has already been reported and/or fixed in 3.4. I've yet to have a chance to try out the BETA.

The wpEditImage plugin creates Edit and Delete buttons for every image on selection. There are several instances where images need to be used as content placeholders like in the instance of the <!-- more --> tag and [gallery] shortcode. The plugin provides a special class "mceItem" which prevents these image editing buttons from appearing on any image with the class.

However, the class apparently isn't checked in all the places it needs to be because you can make these image editing buttons appear even when they're not supposed to. These even occurs in the case of the [gallery] shortcode which has it's own Edit/Delete buttons. If you use one of these hacks, you can actually make the Edit/Delete "Image" buttons appear over the gallery-specific ones.

Here are a few examples and attached are some screenshots:

  1. Firefox 11 Even if an image uses the mceItemNoResize, the resize handles will still appear on hover. If you try to drag these handles, the image doesn't resize (as it shouldn't) but the Edit/Delete image buttons do appear. See Firefox Screenshot Suite
  1. IE 9 Insert a [gallery] and hover your mouse just below an image until the "text editor cursor" appears. Simply click and the Edit/Delete image buttons will appear. You can differentiate these buttons from the Edit/Delete gallery buttons by hovering your mouse over them to read their title text. Unfortunately, I could not get a good screenshot of this.

Note: I could not get this error to occur on Safari or Opera.

Attachments (1)

firefox-more-tag.png (21.7 KB) - added by Master Jake 14 years ago.
Firefox More Tag

Download all attachments as: .zip

Change History (2)

@Master Jake
14 years ago

Firefox More Tag

#1 @ocean90
12 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

In the meantime there were a lot of changes and I can't reproduce both issues in trunk anymore.

This is probably fixed by the TinyMCE update (#24067) or the new Edit Image modal (#24409).

Note: See TracTickets for help on using tickets.