Ability to define post attachment status on insertion

[griffinjt]

By default, wp_insert_attachment will either set a new attachment as 'inherited' or 'private' - inherited being that it simply mimics the post status of its parent.

This is fine by default, but what about when wanting to run tests? For example, you have a live post that you want to add attachments to, but you want to ensure that the attachments (whatever they may be) are properly formatted before making them appear on your live post. By default, just uploading the attachment will push it live because it has inherited the published status of its parent.

Is this doable? What about filtering $object in the wp_parse_args function inside wp_insert_attachment to allow that property (along with the others - it makes sense to be able to filter them all) to be set?

Don't know how feasible it is, but if it's possible I'll work on a patch and tests.

[wonderboymusic]

In 27130:

Add a filter wp_insert_attachment_data in wp_insert_attachment(). This is similar to the wp_insert_post_data filter in wp_insert_post().

Fixes #20547.

[wonderboymusic]

Needs filter docs for wp_insert_attachment_data.

[DrewAPicture]

filter docs

[DrewAPicture]

In 27138:

Inline documentation for the wp_insert_attachment_data filter hook, added in [27130].

Fixes #20547.

[helen]

I'm not sure about this - I closed a duplicate #23399 in favor of #21963. I guess since we'd keep the function as a wrapper it's not a lot of work to keep the hook going forward, but I'm reopening for more feedback.

[wonderboymusic]

are you daring me to combine the two functions? IN-VES-TI-GATING.

[wonderboymusic]

20547.2.diff​ makes wp_insert_attachment() a wrapper for wp_insert_post(), negating the need for this new filter.

[helen]

Replying to wonderboymusic:

are you daring me to combine the two functions? IN-VES-TI-GATING.

I'm actually daring you to go all-in on #21963 :)

[wonderboymusic]

oh wait, that already did all of this over there, will look at refreshing that

[nacin]

Replying to wonderboymusic:

oh wait, that already did all of this over there, will look at refreshing that

Yes, let's keep it on #21963. The two functions have their quirks, you basically need to go line-by-line on them.

[wonderboymusic]

We are attacking the merging of code over here: #21963.