WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#20554 closed enhancement (fixed)

3.4 Feature Pointers

Reported by: ryan Owned by: azaozz
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.4
Component: Help/About Keywords: has-patch
Focuses: Cc:

Description

We need pointers for 3.4 features. Most notably the customizer.

Attachments (6)

20554.diff (4.0 KB) - added by ryan 3 years ago.
Allow multiple pointers per hook name. Rough in pointer to current theme customize link.
20554.2.diff (3.8 KB) - added by scribu 3 years ago.
Filter out dismissed pointers before doing cap checks
20554.3.diff (3.8 KB) - added by ryan 3 years ago.
Refresh
20554.4.diff (2.6 KB) - added by ryan 3 years ago.
Pointer for choosing header image from library
20554.5.diff (3.5 KB) - added by ryan 3 years ago.
custom background too
20554.6.diff (3.5 KB) - added by ryan 3 years ago.
Update phpdoc, make id more generic

Download all attachments as: .zip

Change History (25)

comment:1 @nacin3 years ago

  • Component changed from General to Help/About

comment:2 @ryan3 years ago

Perhaps start with a pointer to the Customize link for the current theme on the themes.php page and a pointer to the customizer sidebar the first time the Customizer is opened.

@ryan3 years ago

Allow multiple pointers per hook name. Rough in pointer to current theme customize link.

comment:3 @ryan3 years ago

The customizer itself seems to short-circuit before admin_enqueue_scripts is fired so WP_Internal_Pointers::enqueue_scripts() never runs.

comment:4 @scribu3 years ago

The @since is wrong for pointer_wp340_customize_current_theme_link().

Also, why are we keeping the pointers from 3.3?

comment:5 @scribu3 years ago

Nevermind, I get it: for users that upgrade directly from 3.2 or earlier.

@scribu3 years ago

Filter out dismissed pointers before doing cap checks

comment:6 @scribu3 years ago

20554.2.diff: small enhancement: use array_diff() to filter out disabled pointers, before doing cap checks.

comment:7 @scribu3 years ago

  • Keywords has-patch added

comment:8 @ocean903 years ago

  • Cc ocean90 added

@ryan3 years ago

Refresh

comment:9 @ryan3 years ago

In [20774]:

First pass at 3.4 pointers. Add pointer to the customize link for the current theme on themes.php. Support multiple pointers per page. Props scribu. see #20554

@ryan3 years ago

Pointer for choosing header image from library

comment:10 @ryan3 years ago

There's a pointer for choose from lib. Figuring a pointer for all the things we'll be featuring on the about page. Customizer, choose header from lib, flex headers, html captions.

@ryan3 years ago

custom background too

@ryan3 years ago

Update phpdoc, make id more generic

comment:11 @ryan3 years ago

In [20839]:

Feature pointers for choosing an image from the library on the custom header and background pages. see #20554

comment:12 @jane3 years ago

On themes pointer, for 2nd paragraph, maybe change to "Click the Live Preview links in the Available Themes list below to customize and preview another theme before activating it."

comment:13 @ryan3 years ago

In [20854]:

Updated text for Customize pointer. Props jane. see #20554

comment:14 @azaozz3 years ago

In [20867]:

Pointers: add arg to pointer options to load at window.loaded (after all images have been loaded and the layout is finalized) and use it on the custom header screen, see #20554

comment:15 @nacin3 years ago

Can we call it defer or defer_loaded? Would like the spelling to be correct. :-)

comment:16 @azaozz3 years ago

In [20869]:

s/deffer/defer, see #20554

comment:17 @azaozz3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [20880]:

Pointers: center pointer on Themes screen, fixes #20554

comment:18 @markjaquith3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This is still broken. Chrome. OS X. Load the page. Reload. Points to the wrong location.

comment:19 @azaozz3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [20891]:

Pointers: fix check for defer_loading, fixes #20554

Note: See TracTickets for help on using tickets.