WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #20564, comment 53


Ignore:
Timestamp:
04/03/2013 06:35:05 AM (7 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #20564, comment 53

    v1 v2  
    22> I took a stab at the `_revision_meta` approach in [attachment:20564.6.diff] which should keep the meta table clean and small for revisions. If this works out we can do the same for revisioned terms (#23893).
    33
    4 Yeah, this works for post formats, not so sure for all meta (only need to add restoring of the post format from 20564-6.patch, perhaps to the same array). Still having empty keys in the serialized array seems wasteful :)
     4Yeah, this works for post formats, not so sure for all meta (only need to add restoring of the post format from 20564-6.patch, perhaps to the same array). Still, having empty keys in the serialized array seems wasteful :)
    55
    66As long as we know the post supports formats, we can recreate the empty keys programmatically, no need to store them in the DB. Example:
     
    1313        ...
    1414  ),
    15   get_post_meta( $preview->ID, '_revision_meta', true )
     15  get_post_meta( $revision->ID, '_revision_meta', true )
    1616);
    1717}}}