WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 2 months ago

#20578 new enhancement

Allow users to delete a plugin without uninstalling

Reported by: scribu Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Plugins Keywords: has-patch dev-feedback
Focuses: ui Cc:

Description

Sometimes, a user may need to delete plugin files without deleting all the plugin data.

Attachments (2)

20578-delete-files-or-both.patch (4.5 KB) - added by kurtpayne 22 months ago.
Separate buttons for delete files and delete files + data
Screen Shot 2014-01-26 at 10.18.28 PM.png (51.1 KB) - added by helen 3 months ago.
After 20578-delete-files-or-both.patch - Jetpack apparently includes another plugin, hence the multiple plugins.

Download all attachments as: .zip

Change History (18)

comment:1 follow-up: scribu2 years ago

Nacin say:

I think it would be good for the uninstall confirmation page to be a choice between "Delete Files and Data" vs "Delete Files". The plugin's uninstall routine would only be fired if the "and Data" was chosen.

comment:2 scribu2 years ago

One scenario: Alice wants to install the development version of a plugin, to test a certain bug fix.

She downloads the zip file. To install it, she first has to remove the existing version.

But, since she has valuable data stored by that plugin, she will have to use FTP to delete the current plugin version, instead of just using wp-admin.

comment:3 in reply to: ↑ 1 ; follow-up: helenyhou2 years ago

Replying to scribu:

Nacin say:

I think it would be good for the uninstall confirmation page to be a choice between "Delete Files and Data" vs "Delete Files". The plugin's uninstall routine would only be fired if the "and Data" was chosen.

Yes, please!

comment:4 wpsmith2 years ago

  • Cc travis@… added

Also in light of the previous ticket, it would be good to have a confirmation screen confirming deletion of plugin v. deletion + data deletion.

comment:5 lightningspirit2 years ago

+1 I suggest to use the current UI and add a new button labeled "Yes, delete both files and data" but perhaps a new design for this confirmation page may improve what we have now.

comment:6 knutsp2 years ago

  • Cc knut@… added

+1 Sometimes a plugin gets partly (un)installed during automatic update due to failing to delete the plugin folder (in use error) or a request timeout. To be able to reinstall a plugin you then must delete it, either trough FTP or the proposed delete without uninstalling action.

Plugins page should als list folders without a valid plugin inside (empty or not) and offer to delete that folder and contents. Separate ticket for this?

comment:7 scribu2 years ago

Plugins page should als list folders without a valid plugin inside (empty or not) and offer to delete that folder and contents. Separate ticket for this?

Yes, please.

comment:8 ryanduff22 months ago

  • Cc ryan@… added

comment:9 kurtpayne22 months ago

  • Cc kpayne@… added

comment:10 DH-Shredder22 months ago

  • Cc mike.schroder@… added

kurtpayne22 months ago

Separate buttons for delete files and delete files + data

comment:11 in reply to: ↑ 3 kurtpayne22 months ago

  • Keywords has-patch dev-feedback added

Replying to helenyhou:

Replying to scribu:

Nacin say:

I think it would be good for the uninstall confirmation page to be a choice between "Delete Files and Data" vs "Delete Files". The plugin's uninstall routine would only be fired if the "and Data" was chosen.

Yes, please!

20578-delete-files-or-both.patch is a first attempt at this. It needs some language rework, and maybe a UX update (someone will be confused by 3 buttons). And having duplicate forms for the presentation logic feels clunky.

comment:12 helen3 months ago

  • Focuses ui added
  • Keywords needs-ui removed

Cool, patch still applies. Thoughts on the UI/UX front:

  • The return to plugin list button really should be a link, and should be now, too.
  • You are correct, some language needs reworking.

Will upload a screenshot momentarily for convenient discussion without having to apply the patch.

helen3 months ago

After 20578-delete-files-or-both.patch - Jetpack apparently includes another plugin, hence the multiple plugins.

comment:13 celloexpressions3 months ago

Could we make one of the buttons primary? Three flat options is tough, even if we tweak the wording.

comment:14 grapplerulrich2 months ago

Related: 8783

The second answer does not fully match the question.

Are you sure you wish to delete these files and data?
Yes, Delete only the files.

A better question would be "Are you sure you want to uninstall these plugins?"

comment:15 Ipstenu2 months ago

Or a better answer of "No, delete only the files."

Also why are we capitalizing 'Delete' here, following a comma?

comment:16 helen2 months ago

Ahem, you guys. kurtpayne said that he knows the language needs reworking/actual attention.

Note: See TracTickets for help on using tickets.