WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#20583 closed defect (bug) (fixed)

RTL style fixes for the install theme info sidebar

Reported by: ocean90 Owned by: ryan
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.4
Component: RTL Keywords: has-patch
Focuses: Cc:

Description

See before.png and after.png.

Attachments (6)

20583.patch (1.6 KB) - added by ocean90 2 years ago.
before.png (94.9 KB) - added by ocean90 2 years ago.
after.png (93.4 KB) - added by ocean90 2 years ago.
20583.diff (1.1 KB) - added by ryan 2 years ago.
20673.use-rtl-star.patch (1.2 KB) - added by ocean90 2 years ago.
20583.2.diff (1.1 KB) - added by helenyhou 2 years ago.

Download all attachments as: .zip

Change History (15)

ocean902 years ago

ocean902 years ago

ocean902 years ago

comment:1 follow-up: helenyhou2 years ago

Looks good. There's an issue with the sidebar collapse but it's not theme install specific.

comment:2 in reply to: ↑ 1 ocean902 years ago

Replying to helenyhou:

Right, this is fixed in #20585.

comment:3 ryan2 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [20673]:

RTL style fixes for the install theme info sidebar. Props ocean90. fixes #20583

comment:4 helenyhou2 years ago

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

There's a stars.rtl.png now, so ocean90's small hack can be removed.

ryan2 years ago

comment:5 follow-up: ryan2 years ago

Like so?

ocean902 years ago

comment:6 ocean902 years ago

  • Keywords has-patch added; needs-patch removed

comment:7 in reply to: ↑ 5 ocean902 years ago

Replying to ryan:

Like so?

No, more like 20673.use-rtl-star.patch.

helenyhou2 years ago

comment:8 helenyhou2 years ago

20583.2.diff gets rids of some unnecessary old star CSS from the RTL sheet and moves the new star CSS into the more appropriate spot, since it also affects the details in the list table. So maybe more like that.

comment:9 ryan2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [20763]:

Use stars-rtl.png for RTL start support in the theme installer. Props helenyhou, ocean90. fixes #20583

Note: See TracTickets for help on using tickets.