WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#20586 closed defect (bug) (fixed)

fix css for vertical-align value to be 'middle', not 'center'

Reported by: bananastalktome Owned by: azaozz
Milestone: 3.5 Priority: normal
Severity: minor Version: 3.3
Component: UI Keywords: has-patch
Focuses: Cc:

Description

Minor fix to wp-admin stylesheet, fixing vertical-align property to have the value 'middle' instead of 'center' (note: Not tested in UI, so I am not sure if this results in any unforeseen layout issues. Just correcting the invalid CSS in place).

Attachments (2)

patch.diff (510 bytes) - added by bananastalktome 7 years ago.
20586.diff (458 bytes) - added by helenyhou 7 years ago.

Download all attachments as: .zip

Change History (8)

#1 @coffee2code
7 years ago

  • Keywords ui-feedback added
  • Version set to 3.3

The first of the two occurrences was introduced in r18803 (the second from some time earlier).

#2 @helenyhou
7 years ago

  • Keywords ui-feedback removed

Related (invalid CSS): #20587. Since this one might have side effects, let's remember to come back to it when we do the anticipated 3.5-early CSS sweep and test/review thoroughly.

#3 @SergeyBiryukov
7 years ago

  • Keywords 3.5-early added

#4 @markjaquith
7 years ago

Waiting on a review for this one, as it might have side effects.

@helenyhou
7 years ago

#5 @helenyhou
7 years ago

  • Keywords needs-testing 3.5-early removed
  • Milestone changed from Awaiting Review to 3.5

As far as I can tell, these aren't needed at all. That they weren't noticed before says something (maybe), and poking at various values didn't change anything visually in either case, try as I might. Let's remove them instead! 20586.diff

#6 @azaozz
7 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [21582]:

Remove erroneous vertical-align: center values, props helenyhou, fixes #20586

Note: See TracTickets for help on using tickets.