WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 9 years ago

#20587 closed defect (bug) (fixed)

Invalid CSS with 'border-right-color: none'

Reported by: bananastalktome Owned by: markjaquith
Milestone: 3.5 Priority: normal
Severity: minor Version: 3.3
Component: UI Keywords: has-patch commit
Focuses: Cc:

Description

I came across several instances where we had 'border-right-color: none' in the stylesheets. Because 'none' is not a valid color value, the style appears to be ignored. I am not sure what (or if?) to change these to, but they appear as follows:

./wp-admin/css/colors-classic.dev.css:2356:
./wp-admin/css/colors-classic.dev.css:2390:
./wp-admin/css/colors-classic.dev.css:2421:
./wp-admin/css/colors-fresh.dev.css:1962:
./wp-admin/css/colors-fresh.dev.css:1996:
./wp-admin/css/colors-fresh.dev.css:2027:

Attachments (3)

20587.diff (1.5 KB) - added by sabreuse 10 years ago.
20587.2.diff (420 bytes) - added by SergeyBiryukov 10 years ago.
20587.3.diff (408 bytes) - added by SergeyBiryukov 9 years ago.
Refreshed after [21592]

Download all attachments as: .zip

Change History (15)

#1 @bananastalktome
10 years ago

Another oddball border issue: ./wp-includes/css/editor.dev.css:1992 sets property border-bottom-right-left (should this be border-bottom-left-radius maybe?)

#2 @helenyhou
10 years ago

  • Keywords dev-feedback removed

Let's make a note to discuss this and #20586 (and invalid CSS in general) today in #wordpress-ui.

The value you'd want instead of none is transparent.

#3 @helenyhou
10 years ago

  • Keywords 3.5-early needs-patch added

#4 @coffee2code
10 years ago

  • Version set to 3.3

The border-right-color: none lines were merged in from the formerly-separate rtl CSS files (see r18579). They only apply for rtl.

@sabreuse
10 years ago

#5 @sabreuse
10 years ago

20587.diff fixes the border-color: none instances mentioned.

#6 @coffee2code
10 years ago

  • Keywords has-patch added; needs-patch removed

#7 @SergeyBiryukov
10 years ago

  • Keywords 3.5-early removed
  • Milestone changed from Awaiting Review to 3.5

#8 @markjaquith
10 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In [21188]:

border-right-color: none; should be border-right-color: transparent; props sabreuse. fixes #20587

#9 @SergeyBiryukov
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#10 @lessbloat
9 years ago

20587.2.diff is a no-brainer. :-) Looks good.

#11 @helenyhou
9 years ago

  • Keywords commit added

@SergeyBiryukov
9 years ago

Refreshed after [21592]

#12 @nacin
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [21661]:

Fix typo in CSS. props SergeyBiryukov. fixes #20587.

Note: See TracTickets for help on using tickets.