Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#20591 closed defect (bug) (fixed)

IE 7 shows themes only in one column on Manage/Install Theme screen

Reported by: ocean90 Owned by: azaozz
Milestone: 3.4 Priority: lowest
Severity: normal Version: 3.3
Component: UI Keywords: has-patch commit
Focuses: Cc:



Dramatic exit.

Attachments (3)

20591.patch (342 bytes) - added by ocean90 3 years ago.
20591.action-links.png (136.3 KB) - added by SergeyBiryukov 3 years ago.
20591.2.patch (388 bytes) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 @ocean903 years ago

Of couse, if we can live with that we can close it as wontfix.

@ocean903 years ago

comment:2 @ocean903 years ago

  • Keywords has-patch needs-testing added; needs-ie-patcher needs-patch removed

Patch based on

Setting display: inline-block and then reverting it back to the original display property value inside another rule set does not remove layout, this trick can be used to give layout without the use of conditional comments when you cannot use other properties.


@SergeyBiryukov3 years ago

comment:3 follow-up: @SergeyBiryukov3 years ago

  • Version changed from 3.4 to 3.3

It's the same in 3.3. Seems introduced in #18198.

20591.patch works, but the action links still look weird. 20591.2.patch fixes that as well.

comment:4 in reply to: ↑ 3 @ocean903 years ago

  • Keywords needs-testing removed

Replying to SergeyBiryukov:

Thought it was introduced through the infinite scroll for themes.

Patch looks good. I didn't checked the links (or even noticed it, because in English the strings are shorter.)

comment:5 @helenyhou3 years ago

Nope, definitely my fault from 3.3 and I neglected it :( I assume it's been like this the whole time.

comment:6 @nacin3 years ago

  • Keywords commit added

comment:7 @azaozz3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [20708]:

Fix columns in IE7 on Appearance -> Themes screen, props SergeyBiryukov, fixes #20591

Note: See TracTickets for help on using tickets.