WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#20610 closed defect (bug) (fixed)

Customizer: closing after activation still displays old theme as active

Reported by: duck_ Owned by: koopersmith
Milestone: 3.4 Priority: high
Severity: major Version: 3.4
Component: Appearance Keywords: needs-patch ux-feedback
Focuses: Cc:

Description

  1. Customize an inactive theme
  2. Click "Save and Activate"
  3. Click "Return to Manage Themes"

Expected: See new theme in the "current theme" spot and an activation notice.

Actual: Same screen prior to clicking "Customize".

Since [20645] for #20507 and #19910.

"Save and Activate" should probably cause a refresh.

Change History (5)

comment:1 ocean902 years ago

  • Cc koopersmith added

comment:2 follow-up: ocean902 years ago

  • Keywords ux-feedback added

Should the Customizer be closed after clicking "Save and Activate" ?

comment:3 in reply to: ↑ 2 nacin2 years ago

  • Priority changed from normal to high
  • Severity changed from normal to major

Replying to ocean90:

Should the Customizer be closed after clicking "Save and Activate" ?

I would suggest yes.

comment:4 mp3j3rk2 years ago

I think we should make Save and Activate close the Customizer, and/or add a second button for just saving, and then Save and Activate closes.

This might be a little too much, but what if we updated the theme page with ajax and jQuery? That would make the return from Customizer a little more seamless.

Just an idea...

Last edited 2 years ago by mp3j3rk (previous) (diff)

comment:5 koopersmith2 years ago

  • Owner set to koopersmith
  • Resolution set to fixed
  • Status changed from new to closed

In [20802]:

Theme Customizer: Properly change state when theme is switched. fixes #20610, see #19910.

  • Causes the Manage Themes page to refresh if the customizer is closed after the active theme is switched.
  • Changes the text of the 'Save and Activate' button once the theme has been activated.
  • Improves the naming of the customize control settings.
  • Add events to customize.Loader and make callbacks more flexible.
  • Makes the customize-loader l10n compatible with non-admin settings.
  • Adds WP_Customize->is_current_theme_active().
  • Minor style corrections, including jQuery.attr/prop changes.
Note: See TracTickets for help on using tickets.