WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 2 years ago

#20614 closed enhancement

Making the menus work in Windows Phone 7, and work better in Android / iOS — at Version 3

Reported by: georgestephanis Owned by:
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.4
Component: Toolbar Keywords: has-patch mobile needs-testing
Focuses: Cc:

Description (last modified by helenyhou)

Currently, on Windows Phone 7/7.5, the Toolbar Dropdown menus are non-functional (as there is no ontouchstart functionality in the browser) and the admin flyout menus are also entirely non-functional. This translates roughly to ... there is no way to actually log out of WordPress! (as logout is in the user dropdown menu)

iOS has some built in :hover faking code, but we should also make the admin menu flyouts more accessible and usable on Android -- where you have to touch and hold to activate the flyout/dropdown, and then slide your finger off to not trigger the actual link.

Change History (5)

@georgestephanis3 years ago

comment:1 @georgestephanis3 years ago

  • Keywords tableteers mobile added

@georgestephanis3 years ago

Whoops! I forgot to use wp_is_mobile() at one place.

comment:2 @georgestephanis3 years ago

  • Keywords changed from has-patch tableteers, mobile to has-patch tableteers mobile

A little JS patch that will help the admin menu and the admin bar menus operate properly in mobile devices. This way, if it's hidden, the first click will show it, and prevent the link from going anywhere. Huzzah! 20614.1.diff

I've probably put some things in the wrong places, and I know nacin/koopersmith sounded like there was another optimization in the JS they'd like to see (koopersmith: we should bind two handlers when a menu is open. one to stop event propagation any time the #adminmenu is clicked, the other to close the menu any time the body is clicked), but I couldn't seem to wrap my head around it, so I'm tapping out to let someone else put the last bit of spit and polish on it.

Last edited 3 years ago by helenyhou (previous) (diff)

comment:3 @helenyhou3 years ago

  • Component changed from UI to Toolbar
  • Description modified (diff)
Note: See TracTickets for help on using tickets.