WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20618 closed enhancement (fixed)

Don't show installed themes in search results

Reported by: DrewAPicture Owned by: ryan
Milestone: 3.4 Priority: high
Severity: minor Version: 3.4
Component: Customize Keywords: ux-feedback has-patch
Focuses: Cc:

Description

Currently, running a search via Install Themes displays themes I already have installed. Clicking the thumbnail followed by Install in the preview screen understandably fails. We should hide themes we already have installed from the search results.

Repro:

  • Goto Themes > Install Themes
  • (Assuming you have bundled themes installed) Search for something like 'twenty'
  • TwentyTen and TwentyEleven will show in search results

Attachments (2)

20618.patch (2.8 KB) - added by SergeyBiryukov 3 years ago.
20618.2.patch (4.7 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 follow-ups: @helenyhou3 years ago

I think it might be more advisable to have a disabled button in the previewer that says "Installed" in place of the "Install" button and also indicate in the row actions for the theme-install.php screen (which I believe are forthcoming). It would be inconsistent with other search results, both in WP and in other places (e.g. App Store) to exclude things that are already installed rather than having an indicator that you already have it.

Where/when are you thinking the installed themes would be excluded? From the API result or processed by the individual install? Seems to me it's either phone home or muck up pagination :)

comment:2 in reply to: ↑ 1 ; follow-up: @nacin3 years ago

  • Component changed from Themes to Appearance
  • Milestone changed from Awaiting Review to 3.4
  • Priority changed from normal to high
  • Severity changed from normal to minor
  • Version set to 3.4

Replying to helenyhou:

I think it might be more advisable to have a disabled button in the previewer that says "Installed" in place of the "Install" button and also indicate in the row actions for the theme-install.php screen (which I believe are forthcoming).

In 3.3, there was *some* indication that the theme was already installed. Keep in mind, however, that there is another potential state — an update could be available.

I would like to see the click open the customizer, rather than the preview, for an installed theme. This should be easy to do.

comment:3 in reply to: ↑ 1 @DrewAPicture3 years ago

Replying to helenyhou:

It would be inconsistent with other search results, both in WP and in other places (e.g. App Store) to exclude things that are already installed rather than having an indicator that you already have it.

I see your point about consistency. What about an 'Installed' label on themes you've already got installed?

Last edited 3 years ago by DrewAPicture (previous) (diff)

comment:4 in reply to: ↑ 2 @helenyhou3 years ago

Replying to nacin:

In 3.3, there was *some* indication that the theme was already installed. Keep in mind, however, that there is another potential state — an update could be available.

In 3.3 and earlier, it still had the "Install" link, and then in the ensuing Thickbox says "This version is already installed." with a cancel button. Kind of lame. Having the row actions for the search results say something like "Installed? | Customize" instead of whatever it ends up being (something like "Preview and Install", probably) for an already installed theme sounds nice, in addition to the click opening the customizer instead of preview. (Ignore the question mark after "Installed", I just wanted it to appear as something grayed out in Trac.)

comment:5 @helenyhou3 years ago

Meant to specify that it says that for an up-to-date theme in my last comment. A theme with an update available doesn't seem to have an indicator in search results, but does have an "Install Update Now" button in the Thickbox.

@SergeyBiryukov3 years ago

comment:6 @SergeyBiryukov3 years ago

  • Keywords has-patch added

First pass: an attempt to check if the theme is already installed and display an appropriate message on the preview screen.

comment:7 follow-up: @johnbillion3 years ago

The 'newer_installed' and 'latest_installed' cases in 20618.patch should allow the theme to be reinstalled in case a theme has been altered and the user wants to revert it back to the original.

@SergeyBiryukov3 years ago

comment:8 in reply to: ↑ 7 ; follow-up: @SergeyBiryukov3 years ago

Refreshed after [20730].

Replying to johnbillion:

The 'newer_installed' and 'latest_installed' cases in 20618.patch should allow the theme to be reinstalled in case a theme has been altered and the user wants to revert it back to the original.

The ability to reinstall a theme makes sense, but sounds like a separate enhancement to me.

comment:9 @ryan3 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [20751]:

When showing already installed themes in the theme installer list, indicate in the row actions that the theme is installed and offer an update link if updates are available.

Props SergeyBiryukov
Fixes #20618

comment:10 in reply to: ↑ 8 @SergeyBiryukov3 years ago

Replying to SergeyBiryukov:

The ability to reinstall a theme makes sense, but sounds like a separate enhancement to me.

Follow-up: #21097

Note: See TracTickets for help on using tickets.