Don't show installed themes in search results

[DrewAPicture]

Currently, running a search via Install Themes displays themes I already have installed. Clicking the thumbnail followed by Install in the preview screen understandably fails. We should hide themes we already have installed from the search results.

Repro:

• Goto Themes > Install Themes
• (Assuming you have bundled themes installed) Search for something like 'twenty'
• TwentyTen and TwentyEleven will show in search results

[helenyhou]

I think it might be more advisable to have a disabled button in the previewer that says "Installed" in place of the "Install" button and also indicate in the row actions for the theme-install.php screen (which I believe are forthcoming). It would be inconsistent with other search results, both in WP and in other places (e.g. App Store) to exclude things that are already installed rather than having an indicator that you already have it.

Where/when are you thinking the installed themes would be excluded? From the API result or processed by the individual install? Seems to me it's either phone home or muck up pagination :)

[nacin]

Replying to helenyhou:

I think it might be more advisable to have a disabled button in the previewer that says "Installed" in place of the "Install" button and also indicate in the row actions for the theme-install.php screen (which I believe are forthcoming).

In 3.3, there was *some* indication that the theme was already installed. Keep in mind, however, that there is another potential state — an update could be available.

I would like to see the click open the customizer, rather than the preview, for an installed theme. This should be easy to do.

[DrewAPicture]

Replying to helenyhou:
It would be inconsistent with other search results, both in WP and in other places (e.g. App Store) to exclude things that are already installed rather than having an indicator that you already have it.

I see your point about consistency. What about an 'Installed' label on themes you've already got installed?

[helenyhou]

Replying to nacin:

In 3.3, there was *some* indication that the theme was already installed. Keep in mind, however, that there is another potential state — an update could be available.

In 3.3 and earlier, it still had the "Install" link, and then in the ensuing Thickbox says "This version is already installed." with a cancel button. Kind of lame. Having the row actions for the search results say something like "Installed? | Customize" instead of whatever it ends up being (something like "Preview and Install", probably) for an already installed theme sounds nice, in addition to the click opening the customizer instead of preview. (Ignore the question mark after "Installed", I just wanted it to appear as something grayed out in Trac.)

[helenyhou]

Meant to specify that it says that for an up-to-date theme in my last comment. A theme with an update available doesn't seem to have an indicator in search results, but does have an "Install Update Now" button in the Thickbox.

[SergeyBiryukov]

First pass: an attempt to check if the theme is already installed and display an appropriate message on the preview screen.

[johnbillion]

The 'newer_installed' and 'latest_installed' cases in 20618.patch​ should allow the theme to be reinstalled in case a theme has been altered and the user wants to revert it back to the original.

[SergeyBiryukov]

Refreshed after [20730].

Replying to johnbillion:

The 'newer_installed' and 'latest_installed' cases in 20618.patch​ should allow the theme to be reinstalled in case a theme has been altered and the user wants to revert it back to the original.

The ability to reinstall a theme makes sense, but sounds like a separate enhancement to me.

[ryan]

In [20751]:

When showing already installed themes in the theme installer list, indicate in the row actions that the theme is installed and offer an update link if updates are available.

Props SergeyBiryukov
Fixes #20618

[SergeyBiryukov]

Replying to SergeyBiryukov:

The ability to reinstall a theme makes sense, but sounds like a separate enhancement to me.

Follow-up: #21097