WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 23 months ago

#20634 new enhancement

dbDelta is unforgiving about field declarations

Reported by: SidHarrell Owned by:
Milestone: Awaiting Review Priority: normal
Severity: minor Version: 1.5
Component: Database Keywords: has-patch
Focuses: Cc:

Description

the variable type is case sensitive:
int(22) != INT(22)

the mysql type BOOL or BOOLEAN comes back from the db as tinyint(1):
tinyint(1) != BOOLEAN

Not a huge issue, just annoying. Makes dbDelta fire off unnecessary sql.

Attachments (3)

upgrade_1589.patch (1.3 KB) - added by SidHarrell 2 years ago.
upgrade_1651.patch (730 bytes) - added by SidHarrell 2 years ago.
upgrade_1571.patch (966 bytes) - added by SidHarrell 2 years ago.

Download all attachments as: .zip

Change History (8)

SidHarrell2 years ago

comment:1 SidHarrell2 years ago

Also annoying is the fact that in our schema, we have to put 2 spaces in between PRIMARY KEY and the (:

PRIMARY KEY  (
VS
PRIMARY KEY (

This one is more problematic, since the core schema is using the 2 space rule, which would be easy enough to fix with a search and replace, but the patch I have for it would also break every plugin out there that uses the 2 space rule.

Last edited 2 years ago by SidHarrell (previous) (diff)

SidHarrell2 years ago

comment:2 SidHarrell2 years ago

I fixed that second patch to allow for single or double spaces between PRIMARY KEY and the ( so

PRIMARY KEY (

will work, but not break backwards compatibility with

PRIMARY KEY  (

SidHarrell2 years ago

comment:3 scribu2 years ago

+1 on the general idea.

Note that patch names should generally contain the ticket number, instead of some other arbitrary number.

Also, it's not clear which patches are meant to be final and which are just intermediary.

Last edited 2 years ago by scribu (previous) (diff)

comment:4 SidHarrell2 years ago

Sorry about that. I'm new to the whole process.

upgrade_1589.patch (I was referring to the file and line#, sorry) is the patch for the first issue, to compare do a case insensitive comparison of fieldnames and convert the synonyms for boolean to tinyint(1).

upgrade_1651.patch breaks backwards compatibility, so ignore that one.

upgrade_1571.patch allows for single or double spaces after PRIMARY KEY

Thanks!

Version 0, edited 2 years ago by SidHarrell (next)

comment:5 nacin23 months ago

  • Type changed from defect (bug) to enhancement
  • Version changed from 3.4 to 1.5

This was how dbDelta was originally designed. Setting as an enhancement.

Note: See TracTickets for help on using tickets.