define ('RELOCATE', false) does the same thing as RELOCATE, true

[TomAuger]

It's a little unintuitive that define('RELOCATE',false) and define('RELOCATE', true) do the same thing. A viable use-case is in development, leaving the RELOCATE defined, but set to false to easily switch it to 'true' when a site is moved.

Regardless of the use case, I recommend we change the check from

if ( defined( 'RELOCATE' ) )

to

if ( defined( 'RELOCATE' ) && RELOCATE === true )

on line 351 of wp-login.php

[JustinSainton]

Should just be able to check

if ( defined( 'RELOCATE' ) && RELOCATE )

[nacin]

Yes, checking for truthiness here seems proper. No need for identically here, as people will often use 1/0 as well.

[TomAuger]

Good stuff. @JustinSainton thanks for patch. I'm away from my sandbox ATM.

[johnbillion]

This also affects SUNRISE in the same manner, see #20220.

[nacin]

In [21251]:

Only obey the RELOCATE move flag if it evaluates to true. props TomAuger, JustinSainton, fixes #20636.