Make WordPress Core

Opened 2 years ago

Closed 21 months ago

#20640 closed enhancement (fixed)

Twenty Eleven: Update html5shiv aka html5.js

Reported by: ocean90 Owned by: lancewillett
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:


Used version is v1.6.2, current version from http://html5shiv.googlecode.com/svn/trunk/html5.js is pre3.5.

Related to this GitHub commit the version should be without pre.

Attachments (2)

20640.patch (6.0 KB) - added by ocean90 2 years ago.
20640.2.patch (4.7 KB) - added by lancewillett 21 months ago.
Update shiv file to latest 3.6 version

Download all attachments as: .zip

Change History (9)

ocean902 years ago

comment:1 TomAuger2 years ago

  • Keywords needs-refresh added

Actually, 3.6 is a significant update in that it makes requiring the innerShiv.js library obsolete for compatibility with IE8. I would recommend making every effort to include 3.6 or later in Twenty Eleven.

comment:2 nacin2 years ago

Related: #20755.

comment:3 ocean9021 months ago

  • Milestone changed from Awaiting Review to 3.5

Twenty Twelve currently has v3.6RC1.

comment:4 lancewillett21 months ago

Replying to ocean90:

Twenty Twelve currently has v3.6RC1.

I believe this version is considered stable now, we can commit to Twenty Eleven (and update the comment header in Twenty Twelve).

lancewillett21 months ago

Update shiv file to latest 3.6 version

comment:5 lancewillett21 months ago

  • Keywords needs-refresh removed

Note: this html5shiv file is not the print-compatible version.

See the two versions at https://github.com/aFarkas/html5shiv/tree/master/dist.

Do we want the printable elements version instead? That one wraps all HTML5 elements in the given document with extra printable elements.

comment:6 lancewillett21 months ago

Discussing with obenland in IRC today, we agreed to go ahead without the printable elements for both Twenty Twelve and Eleven.

comment:7 lancewillett21 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21390]:

Twenty Eleven: update html5 shiv to 3.6 stable version. Props ocean90, fixes #20640.

Note: See TracTickets for help on using tickets.