Make WordPress Core

Opened 14 years ago

Closed 13 years ago

#20644 closed defect (bug) (fixed)

Date in "Incoming Links" dashboard widget is never shown

Reported by: latz's profile Latz Owned by: nacin's profile nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 2.5
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

The Dashboard widget "Incoming Links" has a checkbox "Display item date?". The date is never shown because there are two variables which are not used, never set, and therefore the date is never displayed (wp-admin/includes/dashboard.php, line 823):

if ( !empty($show_author) || !empty($show_summary) )

I can see no reason for these conditions. Removing them will produce the expected output.

Attachments (2)

20644.diff (717 bytes) - added by Latz 14 years ago.
20644.2.diff (1.1 KB) - added by SergeyBiryukov 14 years ago.

Download all attachments as: .zip

Change History (7)

@Latz
14 years ago

#1 @SergeyBiryukov
14 years ago

  • Component changed from Widgets to Administration
  • Keywords 3.5-early added
  • Milestone changed from Awaiting Review to Future Release
  • Version changed from 3.4 to 2.5

Introduced in [6705]. Related: ticket:6432:1. Makes sense to remove them, I guess.

Should probably also combine the strings for better i18n support (20644.2.diff).

#2 @SergeyBiryukov
13 years ago

  • Keywords 3.5-early removed
  • Milestone changed from Future Release to 3.5

#3 follow-up: @nacin
13 years ago

Seems like using %1, %3, and %4 in the second string could be confusing? Typo, or an attempt at standardizing the placeholders in the first string?

#4 in reply to: ↑ 3 @SergeyBiryukov
13 years ago

Replying to nacin:

Typo, or an attempt at standardizing the placeholders in the first string?

The latter. It's the same as the block in line 809 (all four strings share the same placeholders):
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/includes/dashboard.php#L809

#5 @nacin
13 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21249]:

Fix the 'Display item date' configuration option for the Incoming Links dashboard widget. props Latz, SergeyBiryukov, fixes #20644.

Note: See TracTickets for help on using tickets.